From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Buesch <mb@bu3sch.de>
Subject: Re: dm9000: add set_mac_address()
Date: Sun, 12 Aug 2007 23:45:30 +0200
Message-ID: <200708122345.30386.mb@bu3sch.de>
References: <20070812192741.GB27490@gandalf.sssup.it> <200708122338.08523.mb@bu3sch.de>
Mime-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Cc: jgarzik@pobox.com, netdev@vger.kernel.org
To: Michael Trimarchi <trimarchi@gandalf.sssup.it>
Return-path: <netdev-owner@vger.kernel.org>
Received: from static-ip-62-75-166-246.inaddr.intergenia.de ([62.75.166.246]:41453
	"EHLO vs166246.vserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S938350AbXHLVqW (ORCPT
	<rfc822;netdev@vger.kernel.org>); Sun, 12 Aug 2007 17:46:22 -0400
In-Reply-To: <200708122338.08523.mb@bu3sch.de>
Content-Disposition: inline
Sender: netdev-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

On Sunday 12 August 2007 23:38:08 Michael Buesch wrote:
> On Sunday 12 August 2007 21:27:41 Michael Trimarchi wrote:
> > Implement set_mac_address() for the dm9000 driver.  This allows changing
> > the mac address of the interface.
> > 
> > Signed-off-by: Michael Trimarchi <trimarchi@gandalf.sssup.it>
> > ---
> > 
> > --- linux-2.6.22/drivers/net/dm9000.c.orig	2007-07-09 01:32:17.000000000 +0200
> > +++ linux-2.6.22/drivers/net/dm9000.c	2007-08-12 21:42:50.000000000 +0200
> > @@ -161,6 +161,8 @@ static irqreturn_t dm9000_interrupt(int,
> >  static int dm9000_phy_read(struct net_device *dev, int phyaddr_unsused, int reg);
> >  static void dm9000_phy_write(struct net_device *dev, int phyaddr_unused, int reg,
> >  			   int value);
> > +static int dm9000_eth_set_mac_address(struct net_device *dev, void *p);
> > +
> >  static u16 read_srom_word(board_info_t *, int);
> >  static void dm9000_rx(struct net_device *);
> >  static void dm9000_hash_table(struct net_device *);
> > @@ -546,6 +548,7 @@ dm9000_probe(struct platform_device *pde
> >  	ndev->stop		 = &dm9000_stop;
> >  	ndev->get_stats		 = &dm9000_get_stats;
> >  	ndev->set_multicast_list = &dm9000_hash_table;
> > +	ndev->set_mac_address	 = &dm9000_eth_set_mac_address;
> >  #ifdef CONFIG_NET_POLL_CONTROLLER
> >  	ndev->poll_controller	 = &dm9000_poll_controller;
> >  #endif
> > @@ -986,7 +989,6 @@ read_srom_word(board_info_t * db, int of
> >  	return (ior(db, DM9000_EPDRL) + (ior(db, DM9000_EPDRH) << 8));
> >  }
> >  
> > -#ifdef DM9000_PROGRAM_EEPROM
> >  /*
> >   * Write a word data to SROM
> >   */
> > @@ -1002,6 +1004,34 @@ write_srom_word(board_info_t * db, int o
> >  }
> >  
> >  /*
> > + * dm9000_eth_set_mac_address
> > + *
> > + * Change the interface's mac address.
> > + *
> > + */
> > +static int 
> > +dm9000_eth_set_mac_address(struct net_device *dev, void *p)
> > +{
> > +	board_info_t *db = (board_info_t *) dev->priv;
> > +	struct sockaddr *addr = p;
> > +	int i;
> > +
> > +	if (!is_valid_ether_addr(addr->sa_data))
> > +		return -EADDRNOTAVAIL;
> > +
> > +	if (netif_running(dev))
> > +		return -EBUSY;
> > +
> > +	memcpy(dev->dev_addr, addr->sa_data, dev->addr_len);
> > +
> > +	for (i = 0; i < 3; i++)
> > +		write_srom_word(db, i, ((u16 *)(addr->sa_data))[i]);
> 
> That is broken on BigEndian architectures.
> 

And is it really desired to change the mac in the ROM here?
I'd say this should only write the mac to the device registers
(filters and so on).

-- 
Greetings Michael.