* [METH] Don't use GFP_DMA for zone allocation.
@ 2007-08-15 11:53 Ralf Baechle
2007-08-25 4:40 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Ralf Baechle @ 2007-08-15 11:53 UTC (permalink / raw)
To: Andrew Morton, Jeff Garzik, netdev, linux-mips
IP32 doesn't even have a ZONE_DMA so no point in using GFP_DMA in any
IP32-specific device driver.
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
diff --git a/drivers/net/meth.c b/drivers/net/meth.c
index 92b403b..32bed6b 100644
--- a/drivers/net/meth.c
+++ b/drivers/net/meth.c
@@ -405,7 +405,7 @@ static void meth_rx(struct net_device* dev, unsigned long int_status)
priv->stats.rx_length_errors++;
skb = priv->rx_skbs[priv->rx_write];
} else {
- skb = alloc_skb(METH_RX_BUFF_SIZE, GFP_ATOMIC | GFP_DMA);
+ skb = alloc_skb(METH_RX_BUFF_SIZE, GFP_ATOMIC);
if (!skb) {
/* Ouch! No memory! Drop packet on the floor */
DPRINTK("No mem: dropping packet\n");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [METH] Don't use GFP_DMA for zone allocation.
2007-08-15 11:53 [METH] Don't use GFP_DMA for zone allocation Ralf Baechle
@ 2007-08-25 4:40 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-08-25 4:40 UTC (permalink / raw)
To: Ralf Baechle; +Cc: Andrew Morton, netdev, linux-mips
Ralf Baechle wrote:
> IP32 doesn't even have a ZONE_DMA so no point in using GFP_DMA in any
> IP32-specific device driver.
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-08-25 4:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-15 11:53 [METH] Don't use GFP_DMA for zone allocation Ralf Baechle
2007-08-25 4:40 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).