netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [NET]: Don't do netpoll on per cpu backlog napi struct
@ 2007-08-21 23:08 Thomas Graf
  2007-08-21 23:19 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Thomas Graf @ 2007-08-21 23:08 UTC (permalink / raw)
  To: davem; +Cc: netdev

The per cpu backlog napi struct can't do netpoll and has the
dev member set to NULL. Fixes an oops on boot when netpoll is
enabled.

Signed-off-by: Thomas Graf <tgraf@suug.ch>

Index: net-2.6.24/include/linux/netpoll.h
===================================================================
--- net-2.6.24.orig/include/linux/netpoll.h	2007-08-22 01:02:14.000000000 +0200
+++ net-2.6.24/include/linux/netpoll.h	2007-08-22 01:02:30.000000000 +0200
@@ -75,7 +75,7 @@ static inline void *netpoll_poll_lock(st
 	struct net_device *dev = napi->dev;
 
 	rcu_read_lock(); /* deal with race on ->npinfo */
-	if (dev->npinfo) {
+	if (dev && dev->npinfo) {
 		spin_lock(&napi->poll_lock);
 		napi->poll_owner = smp_processor_id();
 		return napi;

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-21 23:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-21 23:08 [NET]: Don't do netpoll on per cpu backlog napi struct Thomas Graf
2007-08-21 23:19 ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).