From: Krishna Kumar <krkumar2@in.ibm.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: Krishna Kumar <krkumar2@in.ibm.com>
Subject: [PATCH 1/2] E1000: Fix ifdown hang in git-2.6.24
Date: Thu, 23 Aug 2007 14:34:18 +0530 [thread overview]
Message-ID: <20070823090418.13099.89298.sendpatchset@localhost.localdomain> (raw)
Doing napi_disable twice hangs "ifdown" of the device. e1000_down is the
common place to call napi_disable.
Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---
e1000_main.c | 4 ----
1 files changed, 4 deletions(-)
diff -ruNp org/drivers/net/e1000/e1000_main.c new/drivers/net/e1000/e1000_main.c
--- org/drivers/net/e1000/e1000_main.c 2007-08-23 13:32:16.000000000 +0530
+++ new/drivers/net/e1000/e1000_main.c 2007-08-23 13:32:34.000000000 +0530
@@ -1477,10 +1477,6 @@ e1000_close(struct net_device *netdev)
{
struct e1000_adapter *adapter = netdev_priv(netdev);
-#ifdef CONFIG_E1000_NAPI
- napi_disable(&adapter->napi);
-#endif
-
WARN_ON(test_bit(__E1000_RESETTING, &adapter->flags));
e1000_down(adapter);
e1000_power_down_phy(adapter);
next reply other threads:[~2007-08-23 9:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 9:04 Krishna Kumar [this message]
2007-08-23 9:04 ` [PATCH 2/2] [RFC] E1000: Fix hang in netdev_wait_allrefs() Krishna Kumar
2007-08-25 6:08 ` David Miller
2007-08-23 16:11 ` [PATCH 1/2] E1000: Fix ifdown hang in git-2.6.24 Kok, Auke
2007-08-25 6:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823090418.13099.89298.sendpatchset@localhost.localdomain \
--to=krkumar2@in.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).