From: Willy Tarreau <w@1wt.eu>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Prakash Punnoor <prakash@punnoor.de>, Greg KH <gregkh@suse.de>,
stable@kernel.org, netdev@vger.kernel.org,
Ayaz Abdulla <aabdulla@nvidia.com>,
linux-kernel@vger.kernel.org, Chuck Ebbert <cebbert@redhat.com>
Subject: [PATCH] fix realtek phy id in forcedeth
Date: Thu, 23 Aug 2007 21:27:09 +0200 [thread overview]
Message-ID: <20070823192709.GA22729@1wt.eu> (raw)
In-Reply-To: <20070823165513.GA6341@kroah.com>
Hi Greg,
On Thu, Aug 23, 2007 at 09:55:13AM -0700, Greg KH wrote:
> It might help if someone sends a real patch that can be applied :)
This is getting really silly now :-) We're all wasting more time
wondering who will send the patch than posting it. I've lost, I got
fed up first, so here it is. Please apply to mainline then stable.
Thanks,
Willy
--
>From a0e2922b99eedd9863232368ea2afe072c52783e Mon Sep 17 00:00:00 2001
From: Willy Tarreau <w@1wt.eu>
Date: Thu, 23 Aug 2007 21:35:41 +0200
Subject: [PATCH] fix realtek phy id in forcedeth
As noticed by Chuck Ebbert, commit c5e3ae8823693b260ce1f217adca8add1bc0b3de
introduced a copy-paste typo, as realtek phy is 0x732 and not 0x1c1. Obvious
fix below suggested by Ayaz Abdulla.
Signed-off-by: Willy Tarreau <w@1wt.eu>
Cc: Ayaz Abdulla <aabdulla@nvidia.com>
Cc: Chuck Ebbert <cebbert@redhat.com>
---
drivers/net/forcedeth.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/forcedeth.c b/drivers/net/forcedeth.c
index 10f4e3b..1938d6d 100644
--- a/drivers/net/forcedeth.c
+++ b/drivers/net/forcedeth.c
@@ -552,7 +552,7 @@ union ring_type {
#define PHY_OUI_MARVELL 0x5043
#define PHY_OUI_CICADA 0x03f1
#define PHY_OUI_VITESSE 0x01c1
-#define PHY_OUI_REALTEK 0x01c1
+#define PHY_OUI_REALTEK 0x0732
#define PHYID1_OUI_MASK 0x03ff
#define PHYID1_OUI_SHFT 6
#define PHYID2_OUI_MASK 0xfc00
--
1.5.2.5
next prev parent reply other threads:[~2007-08-23 19:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070822083844.%N@1wt.eu>
[not found] ` <20070822084026.%N@1wt.eu>
[not found] ` <46CC5CBA.2050901@redhat.com>
2007-08-22 16:10 ` [2.6.20.17 review 35/58] forcedeth bug fix: realtek phy Willy Tarreau
[not found] ` <20070822204225.GD14132@1wt.eu>
[not found] ` <20070822230526.GC32121@suse.de>
2007-08-23 15:50 ` Prakash Punnoor
2007-08-23 16:55 ` [stable] " Greg KH
2007-08-23 19:27 ` Willy Tarreau [this message]
2007-08-25 4:01 ` [PATCH] fix realtek phy id in forcedeth Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823192709.GA22729@1wt.eu \
--to=w@1wt.eu \
--cc=aabdulla@nvidia.com \
--cc=cebbert@redhat.com \
--cc=gregkh@suse.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=prakash@punnoor.de \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).