From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net/802: indentation cleanup
Date: Fri, 24 Aug 2007 22:42:20 -0700 (PDT) [thread overview]
Message-ID: <20070824.224220.34754828.davem@davemloft.net> (raw)
In-Reply-To: <20070824.223940.56806419.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Fri, 24 Aug 2007 22:39:40 -0700 (PDT)
> From: Stephen Hemminger <shemminger@linux-foundation.org>
> Date: Fri, 17 Aug 2007 18:53:11 -0700
>
> > Run the 802 related protocols through Lindent (and hand cleanup)
> > to fix indentation and whitespace style issues.
>
> Applied to net-2.6.24, thanks.
Actually reverted.
Nothing in the world makes me more furious than a "coding
style" change that wasn't even compile tested.
net/802/tr.c: In function ^[$,1rx^[(Btr_add_rif_info^[$,1ry^[(B:
net/802/tr.c:400: error: expected identifier before ^[$,1rx^[(B!^[$,1ry^[(B token
Stephen I see you do things like this, forget sign offs,
and many other things that all say in big huge letters
"sloppy".
Please shape up and test your changes no matter how trivial.
Thanks.
prev parent reply other threads:[~2007-08-25 5:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-18 1:53 [PATCH] net/802: indentation cleanup Stephen Hemminger
2007-08-25 5:39 ` David Miller
2007-08-25 5:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070824.224220.34754828.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox