netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/5] [TCP] MIB: Add counters for discarded SACK blocks
Date: Fri, 24 Aug 2007 22:56:08 -0700 (PDT)	[thread overview]
Message-ID: <20070824.225608.93637672.davem@davemloft.net> (raw)
In-Reply-To: <1187615793520-git-send-email-ilpo.jarvinen@helsinki.fi>

From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Mon, 20 Aug 2007 16:16:33 +0300

> In DSACK case, some events are not extraordinary, such as packet
> duplication generated DSACK. They can arrive easily below
> snd_una when undo_marker is not set (TCP being in CA_Open),
> counting such DSACKs amoung SACK discards will likely just
> mislead if they occur in some scenario when there are other
> problems as well. Similarly, excessively delayed packets could
> cause "normal" DSACKs. Therefore, separate counters are
> allocated for DSACK events.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>

Also applied, thanks a lot!

  reply	other threads:[~2007-08-25  5:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20 13:16 [PATCH net-2.6.24 0/5] TCP: Cleanups & SACK block validation Ilpo Järvinen
2007-08-20 13:16 ` [PATCH 1/5] [TCP]: Remove unnecessary wrapper tcp_packets_out_dec Ilpo Järvinen
2007-08-20 13:16   ` [PATCH 2/5] [TCP]: tcp_packets_out_inc to tcp_output.c (no callers elsewhere) Ilpo Järvinen
2007-08-20 13:16     ` [PATCH 3/5] [TCP]: Rename tcp_ack_packets_out -> tcp_rearm_rto Ilpo Järvinen
2007-08-20 13:16       ` [PATCH 4/5] [TCP]: Discard fuzzy SACK blocks Ilpo Järvinen
2007-08-20 13:16         ` [PATCH 5/5] [TCP] MIB: Add counters for discarded " Ilpo Järvinen
2007-08-25  5:56           ` David Miller [this message]
2007-08-25  5:55         ` [PATCH 4/5] [TCP]: Discard fuzzy " David Miller
2007-08-25  8:47           ` Ilpo Järvinen
2007-08-25  5:53       ` [PATCH 3/5] [TCP]: Rename tcp_ack_packets_out -> tcp_rearm_rto David Miller
2007-08-25  5:44     ` [PATCH 2/5] [TCP]: tcp_packets_out_inc to tcp_output.c (no callers elsewhere) David Miller
2007-08-25  5:43   ` [PATCH 1/5] [TCP]: Remove unnecessary wrapper tcp_packets_out_dec David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070824.225608.93637672.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ilpo.jarvinen@helsinki.fi \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).