From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [Devel] [PATCH 1/1] Dynamically allocate the loopback device Date: Fri, 24 Aug 2007 10:43:01 -0700 Message-ID: <20070824104301.2f4ff34e@localhost> References: <11879698031215-git-send-email-dlezcano@fr.ibm.com> <46CEFF83.3040003@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: containers-qjLDD68F18O7TbgM5vRIOg@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org To: "Denis V. Lunev" Return-path: In-Reply-To: <46CEFF83.3040003-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org List-Id: netdev.vger.kernel.org On Fri, 24 Aug 2007 19:55:47 +0400 "Denis V. Lunev" wrote: > dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org wrote: > > From: Daniel Lezcano > > > > Doing this makes loopback.c a better example of how to do a > > simple network device, and it removes the special case > > single static allocation of a struct net_device, hopefully > > making maintenance easier. > > > > Applies against net-2.6.24 > > > > Tested on i386, x86_64 > > Compiled on ia64, sparc > > I think that a small note, that initialization order is changed will be > good to record. After this, loopback MUST be allocated before any other > networking subsystem initialization. And this is an important change. > > Regards, > Den Yes, this code would break when other drivers are directly linked in.