From: Al Viro <viro@ftp.linux.org.uk>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Francois Romieu <romieu@fr.zoreil.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] via-velocity: use standard VLAN interface (resend)
Date: Fri, 24 Aug 2007 22:15:47 +0100 [thread overview]
Message-ID: <20070824211547.GW21089@ftp.linux.org.uk> (raw)
In-Reply-To: <20070824135649.509e1fe7@freepuppy.rosehill.hemminger.net>
On Fri, Aug 24, 2007 at 01:56:49PM -0700, Stephen Hemminger wrote:
> static void velocity_init_cam_filter(struct velocity_info *vptr)
> {
> struct mac_regs __iomem * regs = vptr->mac_regs;
> + unsigned short vid;
> - mac_set_cam(regs, 0, (u8 *) & (vptr->options.vid), VELOCITY_VLAN_ID_CAM);
> + mac_set_cam(regs, 0, (u8 *) &vid,
> + VELOCITY_VLAN_ID_CAM);
This mac_set_cam() dreck should be split in two properly typed functions.
next prev parent reply other threads:[~2007-08-24 21:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 20:56 [PATCH] via-velocity: use standard VLAN interface (resend) Stephen Hemminger
2007-08-24 21:15 ` Al Viro [this message]
2007-08-24 21:40 ` [PATCH] via-velocity: more cleanup Stephen Hemminger
2007-08-25 1:18 ` Al Viro
2007-09-29 5:28 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070824211547.GW21089@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).