* [PATCH] Remove write-only variable from pktgen_thread
@ 2007-08-29 13:22 Pavel Emelyanov
2007-08-29 21:33 ` sukadev
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Emelyanov @ 2007-08-29 13:22 UTC (permalink / raw)
To: Andrew Morton
Cc: Oleg Nesterov, Sukadev Bhattiprolu, Linux Containers,
Linux Kernel Mailing List, Linux Netdev List
The pktgen_thread.pid is set to current->pid and is never used
after this. So remove this at all.
Found during isolating the explicit pid/tgid usage.
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
---
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 3a3154e..93695c2 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -380,7 +380,6 @@ struct pktgen_thread {
/* Field for thread to receive "posted" events terminate, stop ifs etc. */
u32 control;
- int pid;
int cpu;
wait_queue_head_t queue;
@@ -3462,8 +3461,6 @@ static int pktgen_thread_worker(void *ar
init_waitqueue_head(&t->queue);
- t->pid = current->pid;
-
pr_debug("pktgen: starting pktgen/%d: pid=%d\n", cpu, task_pid_nr(current));
max_before_softirq = t->max_before_softirq;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove write-only variable from pktgen_thread
2007-08-29 13:22 [PATCH] Remove write-only variable from pktgen_thread Pavel Emelyanov
@ 2007-08-29 21:33 ` sukadev
2007-08-31 5:46 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: sukadev @ 2007-08-29 21:33 UTC (permalink / raw)
To: Pavel Emelyanov
Cc: Andrew Morton, Oleg Nesterov, Linux Containers,
Linux Kernel Mailing List, Linux Netdev List
Pavel Emelianov [xemul@openvz.org] wrote:
| The pktgen_thread.pid is set to current->pid and is never used
| after this. So remove this at all.
|
| Found during isolating the explicit pid/tgid usage.
|
| Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Good observation that its not being used :-)
Acked-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
|
| ---
|
| diff --git a/net/core/pktgen.c b/net/core/pktgen.c
| index 3a3154e..93695c2 100644
| --- a/net/core/pktgen.c
| +++ b/net/core/pktgen.c
| @@ -380,7 +380,6 @@ struct pktgen_thread {
| /* Field for thread to receive "posted" events terminate, stop ifs
| etc. */
|
| u32 control;
| - int pid;
| int cpu;
|
| wait_queue_head_t queue;
| @@ -3462,8 +3461,6 @@ static int pktgen_thread_worker(void *ar
|
| init_waitqueue_head(&t->queue);
|
| - t->pid = current->pid;
| -
| pr_debug("pktgen: starting pktgen/%d: pid=%d\n", cpu,
| task_pid_nr(current));
|
| max_before_softirq = t->max_before_softirq;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove write-only variable from pktgen_thread
2007-08-29 21:33 ` sukadev
@ 2007-08-31 5:46 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-08-31 5:46 UTC (permalink / raw)
To: sukadev; +Cc: xemul, akpm, oleg, containers, linux-kernel, netdev
From: sukadev@us.ibm.com
Date: Wed, 29 Aug 2007 14:33:56 -0700
> Pavel Emelianov [xemul@openvz.org] wrote:
> | The pktgen_thread.pid is set to current->pid and is never used
> | after this. So remove this at all.
> |
> | Found during isolating the explicit pid/tgid usage.
> |
> | Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
>
> Good observation that its not being used :-)
>
> Acked-by: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Patch applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-31 5:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-29 13:22 [PATCH] Remove write-only variable from pktgen_thread Pavel Emelyanov
2007-08-29 21:33 ` sukadev
2007-08-31 5:46 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).