* Re: [PATCH 1/3] netxen: Avoid firmware load in PCI probe
[not found] ` <20070828115603.166212155@netxen.com>
@ 2007-08-30 21:58 ` Arnaldo Carvalho de Melo
2007-08-31 10:53 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2007-08-30 21:58 UTC (permalink / raw)
To: dhananjay; +Cc: netdev, jeff, rob
Em Tue, Aug 28, 2007 at 05:23:25PM +0530, dhananjay@netxen.com escreveu:
> Loading firmware during PCI probe can lead to incorrect initialization,
> rendering the card unusable until next reboot. This was introduced a while
> ago as a workaround for firmware bug, a better workaround was submitted for
> this a while ago. So removing original hack that loads firmware during probe.
>
> Signed-off by: Dhananjay Phadke <dhananjay@netxen.com>
Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com>
I was having these problems and after applying this patch the NIC is
back working, thank you for fixing this!
- Arnaldo
> Index: netdev-2.6/drivers/net/netxen/netxen_nic_main.c
> ===================================================================
> --- netdev-2.6.orig/drivers/net/netxen/netxen_nic_main.c
> +++ netdev-2.6/drivers/net/netxen/netxen_nic_main.c
> @@ -639,10 +639,6 @@ netxen_nic_probe(struct pci_dev *pdev, c
> NETXEN_CRB_NORMALIZE(adapter,
> NETXEN_ROMUSB_GLB_PEGTUNE_DONE));
> /* Handshake with the card before we register the devices. */
> - writel(0, NETXEN_CRB_NORMALIZE(adapter, CRB_CMDPEG_STATE));
> - netxen_pinit_from_rom(adapter, 0);
> - msleep(1);
> - netxen_load_firmware(adapter);
> netxen_phantom_init(adapter, NETXEN_NIC_PEG_TUNE);
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] netxen: ethtool fixes
[not found] ` <20070828115603.981381010@netxen.com>
@ 2007-08-31 10:51 ` Jeff Garzik
2007-08-31 12:12 ` Dhananjay Phadke
0 siblings, 1 reply; 4+ messages in thread
From: Jeff Garzik @ 2007-08-31 10:51 UTC (permalink / raw)
To: dhananjay; +Cc: netdev, rob
dhananjay@netxen.com wrote:
> +static int netxen_nic_set_rx_csum(struct net_device *dev, u32 data)
> +{
> + struct netxen_adapter *adapter = netdev_priv(dev);
> + adapter->rx_csum = 0;
> + return 0;
> +}
Bug: 'data' ignored
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] netxen: Avoid firmware load in PCI probe
[not found] ` <20070828115603.166212155@netxen.com>
2007-08-30 21:58 ` [PATCH 1/3] netxen: Avoid firmware load in PCI probe Arnaldo Carvalho de Melo
@ 2007-08-31 10:53 ` Jeff Garzik
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-08-31 10:53 UTC (permalink / raw)
To: dhananjay; +Cc: netdev, rob
applied patches 1-2
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 3/3] netxen: ethtool fixes
2007-08-31 10:51 ` [PATCH 3/3] netxen: ethtool fixes Jeff Garzik
@ 2007-08-31 12:12 ` Dhananjay Phadke
0 siblings, 0 replies; 4+ messages in thread
From: Dhananjay Phadke @ 2007-08-31 12:12 UTC (permalink / raw)
To: Jeff Garzik; +Cc: netdev, rob
oops, ok regenerating patch 3 only.
On Fri, 31 Aug 2007, Jeff Garzik wrote:
> dhananjay@netxen.com wrote:
> > +static int netxen_nic_set_rx_csum(struct net_device *dev, u32 data)
> > +{
> > + struct netxen_adapter *adapter = netdev_priv(dev);
> > + adapter->rx_csum = 0;
> > + return 0;
> > +}
>
> Bug: 'data' ignored
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-08-31 12:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20070828115324.839681763@netxen.com>
[not found] ` <20070828115603.981381010@netxen.com>
2007-08-31 10:51 ` [PATCH 3/3] netxen: ethtool fixes Jeff Garzik
2007-08-31 12:12 ` Dhananjay Phadke
[not found] ` <20070828115603.166212155@netxen.com>
2007-08-30 21:58 ` [PATCH 1/3] netxen: Avoid firmware load in PCI probe Arnaldo Carvalho de Melo
2007-08-31 10:53 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).