* [PATCH] skge: unbalanced parenthesis fix
@ 2007-09-01 6:10 Mariusz Kozlowski
2007-09-01 12:55 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Mariusz Kozlowski @ 2007-09-01 6:10 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Andrew Morton, lkml, netdev
Hello,
This patch fixes unbalanced parenthesis.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
drivers/net/skge.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.23-rc4-mm1-a/drivers/net/skge.h 2007-09-01 07:23:52.000000000 +0200
+++ linux-2.6.23-rc4-mm1-b/drivers/net/skge.h 2007-09-01 07:37:55.000000000 +0200
@@ -1351,7 +1351,7 @@ enum {
PHY_M_PC_EN_DET_PLUS = 3<<8, /* Energy Detect Plus (Mode 2) */
};
-#define PHY_M_PC_MDI_XMODE(x) ((((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
+#define PHY_M_PC_MDI_XMODE(x) (((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
enum {
PHY_M_PC_MAN_MDI = 0, /* 00 = Manual MDI configuration */
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] skge: unbalanced parenthesis fix
2007-09-01 6:10 [PATCH] skge: unbalanced parenthesis fix Mariusz Kozlowski
@ 2007-09-01 12:55 ` Stephen Hemminger
2007-09-01 16:29 ` Mariusz Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2007-09-01 12:55 UTC (permalink / raw)
To: Mariusz Kozlowski; +Cc: Andrew Morton, lkml, netdev
On Sat, 1 Sep 2007 08:10:12 +0200
Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:
> Hello,
>
> This patch fixes unbalanced parenthesis.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/net/skge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.23-rc4-mm1-a/drivers/net/skge.h 2007-09-01 07:23:52.000000000 +0200
> +++ linux-2.6.23-rc4-mm1-b/drivers/net/skge.h 2007-09-01 07:37:55.000000000 +0200
> @@ -1351,7 +1351,7 @@ enum {
> PHY_M_PC_EN_DET_PLUS = 3<<8, /* Energy Detect Plus (Mode 2) */
> };
>
> -#define PHY_M_PC_MDI_XMODE(x) ((((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
> +#define PHY_M_PC_MDI_XMODE(x) (((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
>
> enum {
> PHY_M_PC_MAN_MDI = 0, /* 00 = Manual MDI configuration */
Since the macro is unused, I would rather just drop it.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] skge: unbalanced parenthesis fix
2007-09-01 12:55 ` Stephen Hemminger
@ 2007-09-01 16:29 ` Mariusz Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Mariusz Kozlowski @ 2007-09-01 16:29 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Andrew Morton, lkml, netdev
> > This patch fixes unbalanced parenthesis.
> >
> > Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
> >
> > drivers/net/skge.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-2.6.23-rc4-mm1-a/drivers/net/skge.h 2007-09-01 07:23:52.000000000 +0200
> > +++ linux-2.6.23-rc4-mm1-b/drivers/net/skge.h 2007-09-01 07:37:55.000000000 +0200
> > @@ -1351,7 +1351,7 @@ enum {
> > PHY_M_PC_EN_DET_PLUS = 3<<8, /* Energy Detect Plus (Mode 2) */
> > };
> >
> > -#define PHY_M_PC_MDI_XMODE(x) ((((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
> > +#define PHY_M_PC_MDI_XMODE(x) (((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
> >
> > enum {
> > PHY_M_PC_MAN_MDI = 0, /* 00 = Manual MDI configuration */
>
> Since the macro is unused, I would rather just drop it.
Ok. Here it goes:
Remove broken and unused PHY_M_PC_MDI_XMODE macro.
Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
drivers/net/skge.h | 2 --
1 file changed, 2 deletions(-)
--- linux-2.6.23-rc4-mm1-a/drivers/net/skge.h 2007-09-01 07:23:52.000000000 +0200
+++ linux-2.6.23-rc4-mm1-b/drivers/net/skge.h 2007-09-01 18:25:30.000000000 +0200
@@ -1351,8 +1351,6 @@ enum {
PHY_M_PC_EN_DET_PLUS = 3<<8, /* Energy Detect Plus (Mode 2) */
};
-#define PHY_M_PC_MDI_XMODE(x) ((((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
-
enum {
PHY_M_PC_MAN_MDI = 0, /* 00 = Manual MDI configuration */
PHY_M_PC_MAN_MDIX = 1, /* 01 = Manual MDIX configuration */
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-09-01 16:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-01 6:10 [PATCH] skge: unbalanced parenthesis fix Mariusz Kozlowski
2007-09-01 12:55 ` Stephen Hemminger
2007-09-01 16:29 ` Mariusz Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).