Re: [TG3]: Workaround MSI bug on 5714/5780.

[Andy Gospodarek <andy@greyhouse.net>]

On Thu, Sep 06, 2007 at 04:02:35AM -0700, David Miller wrote:
> From: "Michael Chan" <mchan@broadcom.com>
> Date: Wed, 05 Sep 2007 13:07:08 -0700
> 
> > [TG3]: Workaround MSI bug on 5714/5780.
> > 
> > A hardware bug was revealed after a recent PCI MSI patch was made to
> > always disable legacy INTX when enabling MSI.  The 5714/5780 chips
> > will not generate MSI when INTX is disabled, causing MSI failure
> > messages to be reported, and another patch was made to workaround the
> > problem by disabling MSI on ServerWorks HT1000 bridge chips commonly
> > found with the 5714.
> > 
> > We workaround this chip bug by enabling INTX after we enable MSI and
> > after we resume from suspend.
> > 
> > Update version to 3.81.
> > 
> > This problem was discovered by David Miller.
> > 
> > Signed-off-by: Michael Chan <mchan@broadcom.com>
> 
> Thanks a lot Michael, I'll apply this and work on reverting that
> incorrect MSI chipset quirk too.

Michael,

Is is really necessary to get rid of the HT1000 patch?

commit e3008dedff4bdc96a5f67224cd3d8d12237082a0
Author: Andy Gospodarek <andy@greyhouse.net>
Date:   Thu May 10 22:58:57 2007 -0700

    PCI: disable MSI by default on systems with Serverworks HT1000 chips

This patch was designed to address tg3 and bnx2 messages printed on
systems with HT1000 chips IIRC.  Are we going back to those messages on
bnx2 or is there a workaround in that driver needed too?

-andy