* dgrs: sparse warnings
@ 2007-09-06 12:55 Stephen Hemminger
2007-09-06 13:30 ` maximilian attems
0 siblings, 1 reply; 5+ messages in thread
From: Stephen Hemminger @ 2007-09-06 12:55 UTC (permalink / raw)
To: Al Viro, Jeff Garzik; +Cc: netdev
The dgrs driver is crap and assumes direct access to PCI iomem.
CHECK drivers/net/dgrs.c
drivers/net/dgrs.c:314:20: warning: cast removes address space of expression
drivers/net/dgrs.c:330:12: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:330:12: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:330:12: got void *<noident>
drivers/net/dgrs.c:1003:14: warning: incorrect type in assignment (different address spaces)
drivers/net/dgrs.c:1003:14: expected char *[usertype] vmem
drivers/net/dgrs.c:1003:14: got void [noderef] <asn:2>*
drivers/net/dgrs.c:1023:17: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1023:17: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1023:17: got char *[usertype] vmem
drivers/net/dgrs.c:1052:16: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1052:16: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1052:16: got char *[usertype] vmem
drivers/net/dgrs.c:1106:16: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1106:16: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1106:16: got char *[usertype] vmem
drivers/net/dgrs.c:1369:15: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1369:15: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1369:15: got char *[usertype] vmem
drivers/net/dgrs.c:1371:12: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1371:12: expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1371:12: got unsigned char [usertype] *<noident>
Perhaps we should just mark it as BROKEN in Kconfig
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: dgrs: sparse warnings
2007-09-06 12:55 dgrs: sparse warnings Stephen Hemminger
@ 2007-09-06 13:30 ` maximilian attems
2007-09-06 13:50 ` [patch] dgrs removal maximilian attems
0 siblings, 1 reply; 5+ messages in thread
From: maximilian attems @ 2007-09-06 13:30 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Al Viro, Jeff Garzik, netdev
On Thu, Sep 06, 2007 at 01:55:47PM +0100, Stephen Hemminger wrote:
> The dgrs driver is crap and assumes direct access to PCI iomem.
>
dgrs wants to be removed, it has no users.
(no bug report in bugzilla nor in debian nor in google)
the firmware is not distrutable.
i'll resend my removal patch bzipped and attached.
--
maks
^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch] dgrs removal
2007-09-06 13:30 ` maximilian attems
@ 2007-09-06 13:50 ` maximilian attems
2007-09-06 14:16 ` maximilian attems
0 siblings, 1 reply; 5+ messages in thread
From: maximilian attems @ 2007-09-06 13:50 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Al Viro, Jeff Garzik, netdev, Andres Salomon, Alan
[-- Attachment #1: Type: text/plain, Size: 1396 bytes --]
nobody objected to adrian's rfc dropping dgrs on netdev back in dec. 2006.
-> http://marc.info/?l=linux-netdev&m=116507999803538&w=2
as bonus points this will get rid of a proprietary licensed firmware.
"The dgrs driver is crap and assumes direct access to PCI iomem"
- Stephen Hemminger <shemminger@linux-foundation.org>
dgrs has no users and it's hardware was never shipped.
Signed-off-by: maximilian attems <max@stro.at>
Acked-by: Andres Salomon <dilinger@debian.org>
Acked-by: Alan <alan@lxorguk.ukuu.org.uk>
find the patch attached, due to netdev size constraints
with the following diffstat
Documentation/networking/dgrs.txt | 52
b/Documentation/networking/00-INDEX | 2
b/MAINTAINERS | 6
b/drivers/net/Kconfig | 15
b/drivers/net/Makefile | 1
b/drivers/net/wireless/rtl8187_dev.c | 1
drivers/net/dgrs.c | 1615 -----
drivers/net/dgrs.h | 38
drivers/net/dgrs_asstruct.h | 37
drivers/net/dgrs_bcomm.h | 148
drivers/net/dgrs_es4h.h | 183
drivers/net/dgrs_ether.h | 135
drivers/net/dgrs_firmware.c | 9966 -----------------------------------
drivers/net/dgrs_i82596.h | 473 -
drivers/net/dgrs_plx9060.h | 175
15 files changed, 1 insertion(+), 12846 deletions(-)
--
maks
[-- Attachment #2: dgrs-removal.bz2 --]
[-- Type: application/octet-stream, Size: 79614 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [patch] dgrs removal
2007-09-06 13:50 ` [patch] dgrs removal maximilian attems
@ 2007-09-06 14:16 ` maximilian attems
2007-09-06 14:24 ` maximilian attems
0 siblings, 1 reply; 5+ messages in thread
From: maximilian attems @ 2007-09-06 14:16 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: Al Viro, Jeff Garzik, netdev, Andres Salomon, Alan
On Thu, Sep 06, 2007 at 03:50:23PM +0200, maximilian attems wrote:
> b/drivers/net/wireless/rtl8187_dev.c | 1
> 15 files changed, 1 insertion(+), 12846 deletions(-)
urrgs that was not meant to be there,
resending..
--
maks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-09-06 14:24 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-06 12:55 dgrs: sparse warnings Stephen Hemminger
2007-09-06 13:30 ` maximilian attems
2007-09-06 13:50 ` [patch] dgrs removal maximilian attems
2007-09-06 14:16 ` maximilian attems
2007-09-06 14:24 ` maximilian attems
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).