From: David Miller <davem@davemloft.net>
To: jirislaby@gmail.com
Cc: akpm@linux-foundation.org, netdev@vger.kernel.org,
e1000-devel@lists.sourceforge.net, auke-jan.h.kok@intel.com
Subject: Re: 2.6.23-rc4-mm1: e1000e napi lockup
Date: Fri, 07 Sep 2007 01:03:38 -0700 (PDT) [thread overview]
Message-ID: <20070907.010338.41638771.davem@davemloft.net> (raw)
In-Reply-To: <46E0FB82.2040000@gmail.com>
From: Jiri Slaby <jirislaby@gmail.com>
Date: Fri, 07 Sep 2007 09:19:30 +0200
> I found a regression in 2.6.23-rc4-mm1 (since -rc3-mm1) in e1000e driver.
> napi_disable(&adapter->napi) in e1000_probe freezes the kernel on boot.
Yes, the semantics changed slightly in the net-2.6.24 tree the
other week and someone needs to fix it up.
The netif_napi_add() implicitly does a napi_disable() call. Device
open must explicitly napi_enable() and device close must explicitly
napi_disable(), and if done elsewhere these calls must be strictly
balanced.
next prev parent reply other threads:[~2007-09-07 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-07 7:19 2.6.23-rc4-mm1: e1000e napi lockup Jiri Slaby
2007-09-07 8:03 ` David Miller [this message]
2007-09-07 16:24 ` Kok, Auke
2007-09-07 23:31 ` Jeff Garzik
2007-09-07 23:40 ` Kok, Auke
2007-09-07 23:49 ` Jeff Garzik
2007-09-07 23:52 ` Kok, Auke
2007-09-09 9:58 ` Jiri Slaby
2007-09-09 22:50 ` Kok, Auke
2007-09-10 6:24 ` Jiri Slaby
2007-09-10 6:31 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070907.010338.41638771.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=auke-jan.h.kok@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=jirislaby@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).