* [PATCH] Freeing alive inet6 address
@ 2007-09-07 10:21 Denis V. Lunev
2007-09-11 9:08 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Denis V. Lunev @ 2007-09-07 10:21 UTC (permalink / raw)
To: den, adobriyan, xemul, dev, kuznet, yoshfuji, davem; +Cc: netdev, devel
From: Denis V. Lunev <den@openvz.org>
addrconf_dad_failure calls addrconf_dad_stop which takes referenced address
and drops the count. So, in6_ifa_put perrformed at out: is extra. This
results in message: "Freeing alive inet6 address" and not released dst entries.
Signed-off-by: Denis V. Lunev <den@openvz.org>
Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
--- ./net/ipv6/ndisc.c.ipv6dad 2007-09-03 16:54:32.000000000 +0400
+++ ./net/ipv6/ndisc.c 2007-09-07 13:34:30.000000000 +0400
@@ -736,7 +736,7 @@ static void ndisc_recv_ns(struct sk_buff
* so fail our DAD process
*/
addrconf_dad_failure(ifp);
- goto out;
+ return;
} else {
/*
* This is not a dad solicitation.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Freeing alive inet6 address
2007-09-07 10:21 [PATCH] Freeing alive inet6 address Denis V. Lunev
@ 2007-09-11 9:08 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-09-11 9:08 UTC (permalink / raw)
To: den; +Cc: adobriyan, xemul, dev, kuznet, yoshfuji, netdev, devel
From: "Denis V. Lunev" <den@openvz.org>
Date: Fri, 7 Sep 2007 14:21:18 +0400
> From: Denis V. Lunev <den@openvz.org>
>
> addrconf_dad_failure calls addrconf_dad_stop which takes referenced address
> and drops the count. So, in6_ifa_put perrformed at out: is extra. This
> results in message: "Freeing alive inet6 address" and not released dst entries.
>
> Signed-off-by: Denis V. Lunev <den@openvz.org>
> Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
I've seen this bug myself just a week before heading to
Europe for conferences and intended to look into it.
Thanks a lot for fixing this, patch applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-11 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-07 10:21 [PATCH] Freeing alive inet6 address Denis V. Lunev
2007-09-11 9:08 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).