From: "Hans-Jürgen Koch" <hjk@linutronix.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
jeff@garzik.org, afleming@freescale.com
Subject: Re: [PATCH resend] Fix a lock problem in generic phy code
Date: Mon, 10 Sep 2007 20:45:50 +0200 [thread overview]
Message-ID: <200709102045.51063.hjk@linutronix.de> (raw)
In-Reply-To: <E1IUf6h-0006qu-00@gondolin.me.apana.org.au>
Am Montag 10 September 2007 schrieb Herbert Xu:
> Hans-J??rgen Koch <hjk@linutronix.de> wrote:
> > The following patch fixes it. Tested on an AT91SAM9263-EK board, kernel
> > 2.6.23-rc4 and -rc3-mm1.
>
> Could you please audit all instances of physdev->lock and add
> _bh where necessary? I can see that at least phys_stop also
> needs the _bh.
I think the patch does all that's necessary. At least, there're no error
messages in the logs anymore. I didn't check if there's an error on
unload, though.
>
> We should also consider whether it makes sense to move the
> timer into a work queue.
Somebody who's more involved in that PHY stuff should probably do that.
I'm on holidays, sitting in a hotel room, and will probably not have the
time to have a deeper look into that.
Thanks,
Hans
next prev parent reply other threads:[~2007-09-10 18:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 12:30 [PATCH] Fix a lock problem in generic phy code Hans-Jürgen Koch
2007-08-31 16:29 ` Hans-Jürgen Koch
2007-09-09 21:36 ` [PATCH resend] " Hans-Jürgen Koch
2007-09-10 8:58 ` Herbert Xu
2007-09-10 18:45 ` Hans-Jürgen Koch [this message]
2007-09-11 2:21 ` Herbert Xu
2007-09-13 4:12 ` [PATCH] " Jeff Garzik
2007-09-13 9:50 ` Hans-Jürgen Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709102045.51063.hjk@linutronix.de \
--to=hjk@linutronix.de \
--cc=afleming@freescale.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).