From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Pierre-Yves Ritschard <pyritschard@echo.fr>
Cc: <netdev@vger.kernel.org>
Subject: Re: sky2.c: length mismatch errors with vlan frames
Date: Tue, 11 Sep 2007 10:10:48 +0200 [thread overview]
Message-ID: <20070911101048.02509747@oldman> (raw)
In-Reply-To: <20070910163538.3b23e842@gamma.echo-net.net>
On Mon, 10 Sep 2007 16:35:38 +0200
Pierre-Yves Ritschard <pyritschard@echo.fr> wrote:
> Hi list,
>
> I have been running recent linux kernel on nexcom NSA 1086's equipped
> with sysconnect NICs.
>
> Like some people previously have on this list I am running into
> problems with these NICs and seeing frequent errors in my dmesg:
>
> sky2 eth4: rx error, status 0x402300 length 60
> printk: 17 messages suppressed.
> sky2 eth4: rx error, status 0x402300 length 60
> printk: 32 messages suppressed.
> sky2 eth4: rx error, status 0x602300 length 92
> printk: 25 messages suppressed.
> sky2 eth4: rx error, status 0x6e2300 length 106
> printk: 16 messages suppressed.
> sky2 eth4: rx error, status 0x402300 length 60
> printk: 10 messages suppressed.
> sky2 eth4: rx error, status 0x402300 length 60
> printk: 17 messages suppressed.
> sky2 eth4: rx error, status 0x402300 length 60
>
>
> I have investigated a bit and status doesn't match any of the errors in
> GMR_FS_ANY_ERR.
> The block generating the error is now len_mismatch, due to the fact
> that on packets having the GMR_FS_VLAN bit set, the length argument to
> sky2_receive is 4 bytes shorter that the 16 bit value in status (status
> ``right shift'' 16).
>
> Since both these values are read from the card I don't know how to
> solve this other than by incrementing the length arg by 4 when
> GMR_FS_VLAN is set in status. So here's a diff that does this, although
> I'm not sure its an elegant solution:
>
My bad, I hadn't tested VLAN acceleration code in a while so must
have broken it when more error checking was added.
Your fix looks right. Could you format properly for kernel patch inclusion.
Also, instead of hard coding 4, please use VLAN_HLEN.
next prev parent reply other threads:[~2007-09-11 8:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 14:35 sky2.c: length mismatch errors with vlan frames Pierre-Yves Ritschard
2007-09-11 8:10 ` Stephen Hemminger [this message]
2007-09-11 9:46 ` [PATCH] " Pierre-Yves Ritschard
2007-09-11 9:50 ` Pierre-Yves Ritschard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070911101048.02509747@oldman \
--to=shemminger@linux-foundation.org \
--cc=netdev@vger.kernel.org \
--cc=pyritschard@echo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).