netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: hch@infradead.org
Cc: dada1@cosmosbay.com, herbert@gondor.apana.org.au, netdev@vger.kernel.org
Subject: Re: [PATCH] NET : convert IP route cache garbage colleciton from softirq processing to a workqueue
Date: Wed, 12 Sep 2007 04:10:18 -0700 (PDT)	[thread overview]
Message-ID: <20070912.041018.35029512.davem@davemloft.net> (raw)
In-Reply-To: <20070912100054.GA3649@infradead.org>

From: Christoph Hellwig <hch@infradead.org>
Date: Wed, 12 Sep 2007 11:00:54 +0100

> Can you please et rid of this useless struct?  It just complicates
> the code and means we can't use the proper DEFINE_SPINLOCK initializer.

As long as the linker can move global variables around we need
to do things like this to keep objects together when that's
what we want.

So it's not really useless, but perhaps deserves a comment.

      parent reply	other threads:[~2007-09-12 11:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-11 12:56 [PATCH] NET : convert IP route cache garbage colleciton from softirq processing to a workqueue Eric Dumazet
2007-09-12  9:05 ` David Miller
2007-09-12 10:08   ` Eric Dumazet
2007-09-12 11:12     ` David Miller
2007-09-12 12:16       ` Eric Dumazet
2007-09-12 12:30         ` David Miller
2007-09-12 10:00 ` Christoph Hellwig
2007-09-12 10:18   ` Eric Dumazet
2007-09-12 11:10   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070912.041018.35029512.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=dada1@cosmosbay.com \
    --cc=hch@infradead.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).