From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: xemul@openvz.org, kaber@trash.net, netdev@vger.kernel.org,
shemminger@linux-foundation.org
Subject: Re: [PATCH] veth: Cleanly handle a missing peer_tb argument on creation.
Date: Wed, 12 Sep 2007 06:31:39 -0700 (PDT) [thread overview]
Message-ID: <20070912.063139.55741343.davem@davemloft.net> (raw)
In-Reply-To: <m17imwaumb.fsf@ebiederm.dsl.xmission.com>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Wed, 12 Sep 2007 07:19:56 -0600
>
> I was getting strange kernel crashes when attempting to
> create veth devices when I did not specify a peer argument
> to /bin/ip.
>
> So this patch defaults peer_tb to all zeros and doesn't attempt to
> reuse the netlink attributes for the primary link to create the
> secondary link and now I can't reproduce the failures.
>
> Given that some of the most interesting netlink attributes to specify
> like a mac address or a network device name seem are generally
> the wrong thing to do this seems like the right approach.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
This looks mostly fine, can someone else who knows
veth a bit review this as well?
next prev parent reply other threads:[~2007-09-12 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 13:19 [PATCH] veth: Cleanly handle a missing peer_tb argument on creation Eric W. Biederman
2007-09-12 13:31 ` David Miller [this message]
2007-09-12 14:15 ` Pavel Emelyanov
2007-09-12 14:48 ` Eric W. Biederman
2007-09-12 14:49 ` Pavel Emelyanov
2007-09-12 15:25 ` Eric W. Biederman
2007-09-13 6:06 ` Pavel Emelyanov
2007-09-13 9:02 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912.063139.55741343.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).