From: David Miller <davem@davemloft.net>
To: greearb@candelatech.com
Cc: netdev@vger.kernel.org, kaber@trash.net
Subject: Re: SO_BINDTODEVICE mismatch with man page & comments.
Date: Wed, 12 Sep 2007 08:08:32 -0700 (PDT) [thread overview]
Message-ID: <20070912.080832.52182952.davem@davemloft.net> (raw)
In-Reply-To: <46DDDFFA.6090705@candelatech.com>
From: Ben Greear <greearb@candelatech.com>
Date: Tue, 04 Sep 2007 15:45:14 -0700
> According to the comment in the net/core/sock.c code (in 2.6.20), I should be able to pass a zero
> optlen to the setsockopt method for SO_BINDTODEVICE:
...
>
> However, earlier in that method it returns -EINVAL if optlen is < sizeof(int).
>
> The man page has comments similar to that in the code above.
Yes, the comment definitely does not match the code and
should be fixed one way or the other.
I'll do some code history research to try and figure out
if this optlen==0 case ever worked properly.
Thanks.
next prev parent reply other threads:[~2007-09-12 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-04 22:45 SO_BINDTODEVICE mismatch with man page & comments Ben Greear
2007-09-12 15:08 ` David Miller [this message]
2007-09-14 20:12 ` David Miller
2007-09-14 22:11 ` Ben Greear
2007-09-14 22:29 ` David Miller
2007-09-14 22:37 ` Ben Greear
2007-09-14 22:43 ` David Miller
2007-09-14 23:09 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912.080832.52182952.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=greearb@candelatech.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).