netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jchapman@katalix.com
Cc: netdev@vger.kernel.org, hadi@cyberus.ca, jeff@garzik.org,
	mandeep.baines@gmail.com, ossthema@de.ibm.com
Subject: Re: RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates
Date: Wed, 12 Sep 2007 08:12:11 -0700 (PDT)	[thread overview]
Message-ID: <20070912.081211.13753718.davem@davemloft.net> (raw)
In-Reply-To: <200709061416.l86EG0Vb017675@quickie.katalix.com>

From: James Chapman <jchapman@katalix.com>
Date: Thu, 6 Sep 2007 15:16:00 +0100

> First, do we need to encourage consistency in NAPI poll drivers? A
> survey of current NAPI drivers shows different strategies being used
> in their poll(). Some such as r8169 do the napi_complete() if poll()
> does less work than their allowed budget. Others such as e100 and
> tg3 do napi_complete() only if they do no work at all.

Actually, I want to clarify this situation.  In reality these
drivers are more consistent than different.

For some chips the cheapest way to figure out if there is more
RX work is simply to see if the amount of work processed is
less than "budget".  It's too expensive to recheck the hardware.

On some chips like tg3, it's extremely cheap to see if new work
arrived between the completion of processing the RX queue and
the NAPI completion check, so they do it.

But logically they are testing the same exact high level thing.

  parent reply	other threads:[~2007-09-12 15:12 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-06 14:16 RFC: possible NAPI improvements to reduce interrupt rates for low traffic rates James Chapman
2007-09-06 14:37 ` Stephen Hemminger
2007-09-06 15:30   ` James Chapman
2007-09-06 15:37     ` Stephen Hemminger
2007-09-06 16:07       ` James Chapman
2007-09-06 23:06 ` jamal
2007-09-07  9:31   ` James Chapman
2007-09-07 13:22     ` jamal
2007-09-10  9:20       ` James Chapman
2007-09-10 12:27         ` jamal
2007-09-12  7:04       ` Bill Fink
2007-09-12 12:12         ` jamal
2007-09-12 13:50           ` James Chapman
2007-09-12 14:02             ` Stephen Hemminger
2007-09-12 16:26               ` James Chapman
2007-09-12 16:47               ` Mandeep Baines
2007-09-13  6:57                 ` David Miller
2007-09-14 13:14             ` jamal
2007-09-07 21:20     ` Jason Lunz
2007-09-10  9:25       ` James Chapman
2007-09-07  3:55 ` Mandeep Singh Baines
2007-09-07  9:38   ` James Chapman
2007-09-08 16:42     ` Mandeep Singh Baines
2007-09-10  9:33       ` James Chapman
2007-09-10 12:12       ` jamal
2007-09-08 16:32 ` Andi Kleen
2007-09-10  9:25   ` James Chapman
2007-09-12 15:12 ` David Miller [this message]
2007-09-12 16:39   ` James Chapman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070912.081211.13753718.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=hadi@cyberus.ca \
    --cc=jchapman@katalix.com \
    --cc=jeff@garzik.org \
    --cc=mandeep.baines@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ossthema@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).