From: David Miller <davem@davemloft.net>
To: auke-jan.h.kok@intel.com
Cc: Robert.Olsson@data.slu.se, akpm@linux-foundation.org,
jeff@garzik.org, netdev@vger.kernel.org
Subject: Re: [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git
Date: Wed, 12 Sep 2007 23:55:21 -0700 (PDT) [thread overview]
Message-ID: <20070912.235521.41654166.davem@davemloft.net> (raw)
In-Reply-To: <46E816F5.9010409@intel.com>
From: "Kok, Auke" <auke-jan.h.kok@intel.com>
Date: Wed, 12 Sep 2007 09:42:29 -0700
> David Miller wrote:
> >
> > diff --git a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> > index 7b0bcdb..58bb758 100644
> > --- a/drivers/net/e1000/e1000_main.c
> > +++ b/drivers/net/e1000/e1000_main.c
> > @@ -3944,7 +3944,7 @@ e1000_clean(struct napi_struct *napi, int budget)
> > &work_done, budget);
> >
> > /* If no Tx and not enough Rx work done, exit the polling mode */
> > - if ((tx_cleaned && (work_done < budget)) ||
> > + if ((!tx_cleaned && (work_done < budget)) ||
> > !netif_running(poll_dev)) {
> > quit_polling:
> > if (likely(adapter->itr_setting & 3))
>
>
> Ack, this is exactly what I did to fix e1000e as well.
Thanks for reviewing.
prev parent reply other threads:[~2007-09-13 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-08 0:27 [PATCH] [-MM, FIX V3] e1000e: incorporate napi_struct changes from net-2.6.24.git Auke Kok
2007-09-08 0:30 ` Kok, Auke
2007-09-08 7:53 ` Robert Olsson
2007-09-12 14:53 ` David Miller
2007-09-12 16:42 ` Kok, Auke
2007-09-13 6:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912.235521.41654166.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Robert.Olsson@data.slu.se \
--cc=akpm@linux-foundation.org \
--cc=auke-jan.h.kok@intel.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).