From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Hemminger Subject: Re: [PATCH] [IPROUTE2] Add support for moving links between network namespaces Date: Wed, 12 Sep 2007 16:13:13 +0200 Message-ID: <20070912161313.7868706a@oldman> References: <20070912153909.6b80448f@oldman> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: , Pavel Emelyanov , Patrick McHardy To: ebiederm@xmission.com (Eric W. Biederman) Return-path: Received: from smtp2.linux-foundation.org ([207.189.120.14]:35255 "EHLO smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967282AbXILONB (ORCPT ); Wed, 12 Sep 2007 10:13:01 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Wed, 12 Sep 2007 08:06:08 -0600 ebiederm@xmission.com (Eric W. Biederman) wrote: > Stephen Hemminger writes: > > > On Wed, 12 Sep 2007 07:05:42 -0600 > > ebiederm@xmission.com (Eric W. Biederman) wrote: > > > >> > >> This adds support for setting the IFLA_NET_NS_PID attribute > >> on links allowing them to be moved between network namespaces. > >> > >> Signed-off-by: Eric W. Biederman > >> --- > >> include/linux/if_link.h | 1 + > >> ip/iplink.c | 9 +++++++++ > >> 2 files changed, 10 insertions(+), 0 deletions(-) > > > > Please don't mix header file updates with command changes. > > As a first step, I always install standard kernel santized headers. > > Sorry I didn't know. Those changes are now in net-2.6.24 > so installing sanitized headers should not change anything. > > In please feel free to drop the if_link.h part, and if you want > I can resend that patch with those few lines deleted. > > Eric I take care of fixing patches (as long as they aren't really damaged).