From: Andrew Morton <akpm@linux-foundation.org>
To: "Kok, Auke" <auke-jan.h.kok@intel.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, jeff@garzik.org,
jesse.brandeburg@intel.com
Subject: Re: [PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from net-2.6.24.git
Date: Wed, 12 Sep 2007 16:14:19 -0700 [thread overview]
Message-ID: <20070912161419.f6764d34.akpm@linux-foundation.org> (raw)
In-Reply-To: <46E86611.60307@intel.com>
On Wed, 12 Sep 2007 15:20:01 -0700
"Kok, Auke" <auke-jan.h.kok@intel.com> wrote:
> Andrew Morton wrote:
> > On Wed, 12 Sep 2007 11:13:07 -0700
> > Auke Kok <auke-jan.h.kok@intel.com> wrote:
> >
> >> This incorporates the new napi_struct changes into ixgbe.
> >
> > I get a reject storm.
> >
> >> --- a/drivers/net/ixgbe/ixgbe_main.c
> >> +++ b/drivers/net/ixgbe/ixgbe_main.c
> >> @@ -557,14 +557,15 @@ static irqreturn_t ixgbe_msix_clean_rx(int irq, void *data)
> >> struct ixgbe_adapter *adapter = rxr->adapter;
> >>
> >> IXGBE_WRITE_REG(&adapter->hw, IXGBE_EIMC, rxr->eims_value);
> >> - netif_rx_schedule(adapter->netdev);
> >> + netif_rx_schedule(adapter->netdev, &adapter->napi);
> >> return IRQ_HANDLED;
> >> }
> >>
> >
> > For example, my copy of ixgbe_msix_clean_rx(), from
> > git://lost.foo-projects.org/~aveerani/git/linux-2.6#ixgbe is:
>
> please drop that tree, and get the one I posted last week instead:
>
> git://lost.foo-projects.org/~ahkok/linux-2.6 ixgbe-20070905-submission
I think I just ignored that branch. It looks like some frozen-week-old
snapshot, whereas I like to get the latest tip-of-tree.
Or is that branch just misnamed?
next prev parent reply other threads:[~2007-09-12 23:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 18:13 [PATCH] [-MM, FIX] ixgbe: incorporate napi_struct changes from net-2.6.24.git Auke Kok
2007-09-12 22:16 ` Andrew Morton
2007-09-12 22:20 ` Kok, Auke
2007-09-12 23:14 ` Andrew Morton [this message]
2007-09-12 23:29 ` Kok, Auke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912161419.f6764d34.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).