netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: Pavel Emelyanov <xemul@openvz.org>,
	netdev@vger.kernel.org, Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 4/4] [IPROUTE2] iproute2: link_veth support bug fixes.
Date: Thu, 13 Sep 2007 12:30:25 +0200	[thread overview]
Message-ID: <20070913123025.0077d421@oldman> (raw)
In-Reply-To: <m1ir6fapdt.fsf@ebiederm.dsl.xmission.com>

On Wed, 12 Sep 2007 09:13:02 -0600
ebiederm@xmission.com (Eric W. Biederman) wrote:

> Pavel Emelyanov <xemul@openvz.org> writes:
> 
> > [snip]
> >
> >> @@ -25,6 +26,3 @@ clean:
> >>  
> >>  LDLIBS	+= -ldl
> >>  LDFLAGS	+= -Wl,-export-dynamic
> >> -
> >> -%.so: %.c
> >> -	$(CC) $(CFLAGS) -shared $< -o $@
> >
> > %) How do we get the .so file then?
> 
> The code was built into iproute2, so we don't need the .so file.
> That rule does not work on arch/x86_64 so I had to do something
> and the easiest was to simply compile the code in.  Like Patrick
> did with his recent VLAN support.
> 
> The usefulness of a .so file seems to be distributing the code
> outside of /bin/ip.  Although I think we currently have some issues with
> mixed 32bit and 64bit systems because we have "/usr/lib/ip/link_*.so"
> hard coded.
> 
> A .so file always seems to override the compiled in version so I don't
> think we loose any flexibility on that front.
> 
> Eric

Fixing the 64 bit library path is on my to fix list.

      reply	other threads:[~2007-09-13 10:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12 12:55 [PATCH 1/4] [IPROUTE2] Revert "Make ip utility veth driver aware" Eric W. Biederman
2007-09-12 12:55 ` Pavel Emelyanov
2007-09-12 13:09   ` Eric W. Biederman
2007-09-12 13:48     ` Eric W. Biederman
2007-09-12 12:58 ` [PATCH 2/6] [IPROUTE2] Introduce iplink_parse() routine Eric W. Biederman
2007-09-12 12:59   ` [PATCH 3/4] [IPROUTE2] Module for ip utility to support veth device Eric W. Biederman
2007-09-12 13:01     ` [PATCH 4/4] [IPROUTE2] iproute2: link_veth support bug fixes Eric W. Biederman
2007-09-12 13:03       ` [PATCH] [IPROUTE2] Basic documentation for dynamic link creation/destruction Eric W. Biederman
2007-09-12 13:05         ` [PATCH] [IPROUTE2] Add support for moving links between network namespaces Eric W. Biederman
2007-09-12 13:39           ` Stephen Hemminger
2007-09-12 14:06             ` Eric W. Biederman
2007-09-12 14:13               ` Stephen Hemminger
2007-09-12 14:33       ` [PATCH 4/4] [IPROUTE2] iproute2: link_veth support bug fixes Pavel Emelyanov
2007-09-12 15:13         ` Eric W. Biederman
2007-09-13 10:30           ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070913123025.0077d421@oldman \
    --to=shemminger@linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).