netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mchan@broadcom.com
Cc: andy@greyhouse.net, netdev@vger.kernel.org, ananth@broadcom.com,
	nsankar@broadcom.com
Subject: Re: [TG3]: Workaround MSI bug on 5714/5780.
Date: Fri, 14 Sep 2007 15:33:15 -0700 (PDT)	[thread overview]
Message-ID: <20070914.153315.39168469.davem@davemloft.net> (raw)
In-Reply-To: <1189218381.5210.67.camel@dell>

From: "Michael Chan" <mchan@broadcom.com>
Date: Fri, 07 Sep 2007 19:26:21 -0700

> [PCI]: Add MSI quirk for ServerWorks HT1000 PCIX bridge.
> 
> This is the fix for the following problem:
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=227657
> 
> The bnx2 device 5706 complains about MSI not working behind a
> ServerWorks HT1000 PCIX bridge. An earlier commit to fix the problem:
> 
> e3008dedff4bdc96a5f67224cd3d8d12237082a0:
> 
> "PCI: disable MSI by default on systems with Serverworks HT1000 chips"
> 
> was not entirely correct, and has been reverted.
> 
> MSI does not work on the PCIX bus because the BIOS did not set the
> HT_MSI_FLAGS_ENABLE bit in the HyperTransport MSI capability on the
> bridge.  We use the existing quirk_msi_ht_cap() to detect the problem
> and disable MSI in all buses behind it.
> 
> Signed-off-by: Michael Chan <mchan@broadcom.com>
> Cc: Anantha Subramanyam <ananth@broadcom.com>
> Cc: Naren Sankar <nsankar@broadcom.com>

Michael, I've queued this and my revert patch into a tree which
I will push to the PCI maintainer for 2.6.24

Thanks.

  parent reply	other threads:[~2007-09-14 22:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-05 20:07 [TG3]: Workaround MSI bug on 5714/5780 Michael Chan
2007-09-05 19:38 ` Andy Gospodarek
2007-09-06 11:02 ` David Miller
2007-09-06 13:45   ` Andy Gospodarek
2007-09-06 14:34     ` David Miller
2007-09-06 14:40       ` Andy Gospodarek
2007-09-06 15:41       ` Andy Gospodarek
2007-09-06 19:05         ` Michael Chan
2007-09-06 18:26           ` Andy Gospodarek
2007-09-06 19:50           ` David Miller
2007-09-06 20:27             ` Andy Gospodarek
2007-09-08  2:26             ` Michael Chan
2007-09-08 21:25               ` David Miller
2007-09-14 22:33               ` David Miller [this message]
2007-09-06 15:11     ` Michael Chan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070914.153315.39168469.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=ananth@broadcom.com \
    --cc=andy@greyhouse.net \
    --cc=mchan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=nsankar@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).