netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: "Satyam Sharma" <satyam.sharma@gmail.com>
Cc: "Medve Emilian-EMMEDVE1" <Emilian.Medve@freescale.com>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, i2c@lm-sensors.org,
	linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH v3] Make the pr_*() family of macros in kernel.h complete
Date: Fri, 14 Sep 2007 10:13:29 -0700	[thread overview]
Message-ID: <20070914101329.60d42ca7.randy.dunlap@oracle.com> (raw)
In-Reply-To: <a781481a0709140941w4ec76582j40ee53a189b99b05@mail.gmail.com>

On Fri, 14 Sep 2007 22:11:59 +0530 Satyam Sharma wrote:

> > > -----Original Message-----
> > > From: Medve Emilian-EMMEDVE1
> > > Sent: Wednesday, September 12, 2007 11:40 AM
> > > To: linux-kernel@vger.kernel.org; netdev@vger.kernel.org;
> > > i2c@lm-sensors.org; linux-omap-open-source@linux.omap.com
> > > Cc: Medve Emilian-EMMEDVE1
> 
> ... no maintainer explicitly copied on the original mail who'd push this in.
> Little thing, but LKML is too noisy, so you need to Cc: folks explicitly ...
> 
> > > Subject: [PATCH v3] Make the pr_*() family of macros in
> > > kernel.h complete
> > >
> > > Other/Some pr_*() macros are already defined in kernel.h, but
> > > pr_err() was defined
> > > multiple times in several other places
> > >
> > > Signed-off-by: Emil Medve <Emilian.Medve@Freescale.com>
> 
> I think it's a useful cleanup, patch looks good to me ...
> 
> Reviewed-by: Satyam Sharma <satyam@infradead.org>

I like it too.

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>

(since I still haven't seen reviewed-by in SubmittingPatches)

> [ Original diff is at: http://lkml.org/lkml/diff/2007/9/12/182/1 ]

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

  reply	other threads:[~2007-09-14 17:18 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-12 16:39 [PATCH v3] Make the pr_*() family of macros in kernel.h complete Emil Medve
2007-09-12 18:04 ` Jan Engelhardt
2007-09-12 18:44   ` Medve Emilian-EMMEDVE1
2007-09-13  5:11     ` Joe Perches
2007-09-13 14:32       ` [PATCH v3] Make the pr_*() family of macros in kernel.hcomplete Medve Emilian-EMMEDVE1
2007-09-14 13:27 ` [PATCH v3] Make the pr_*() family of macros in kernel.h complete Medve Emilian-EMMEDVE1
2007-09-14 16:41   ` Satyam Sharma
2007-09-14 17:13     ` Randy Dunlap [this message]
2007-09-14 20:18   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070914101329.60d42ca7.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=Emilian.Medve@freescale.com \
    --cc=akpm@linux-foundation.org \
    --cc=i2c@lm-sensors.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap-open-source@linux.omap.com \
    --cc=netdev@vger.kernel.org \
    --cc=satyam.sharma@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).