From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: tgraf@suug.ch, netdev@vger.kernel.org
Subject: Re: [NETLINK]: Avoid pointer in netlink_run_queue
Date: Sun, 16 Sep 2007 16:31:14 -0700 (PDT) [thread overview]
Message-ID: <20070916.163114.21928669.davem@davemloft.net> (raw)
In-Reply-To: <20070831120930.GA29914@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 31 Aug 2007 20:09:30 +0800
> Hi Dave:
>
> [NETLINK]: Avoid pointer in netlink_run_queue
>
> I was looking at Patrick's fix to inet_diag and it occured
> to me that we're using a pointer argument to return values
> unnecessarily in netlink_run_queue. Changing it to return
> the value will allow the compiler to generate better code
> since the value won't have to be memory-backed.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied to net-2.6.24, thanks Herbert.
prev parent reply other threads:[~2007-09-16 23:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-31 12:09 [NETLINK]: Avoid pointer in netlink_run_queue Herbert Xu
2007-09-16 23:31 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070916.163114.21928669.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox