From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [SKBUFF]: Fix up csum_start when head room changes
Date: Sun, 16 Sep 2007 16:33:19 -0700 (PDT) [thread overview]
Message-ID: <20070916.163319.105429760.davem@davemloft.net> (raw)
In-Reply-To: <20070901011333.GA5223@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sat, 1 Sep 2007 09:13:33 +0800
> Hi Dave:
>
> [SKBUFF]: Fix up csum_start when head room changes
>
> Thanks for noticing the bug where csum_start is not updated
> when the head room changes.
>
> This patch fixes that. It also moves the csum/ip_summed
> copying into copy_skb_header so that skb_copy_expand gets
> it too. I've checked its callers and no one should be upset
> by this.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Herbert, thanks for following up on this.
Although this is technically a "bug fix" we don't have anyone
explicitly triggering this and I don't feel comfortable pushing this
into net-2.6 without a reported failure case right now.
So I applied it to net-2.6.24 for now.
If you disagree, plead your case :-)
prev parent reply other threads:[~2007-09-16 23:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 1:13 [SKBUFF]: Fix up csum_start when head room changes Herbert Xu
2007-09-16 23:33 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070916.163319.105429760.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox