From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH][NETNS] Use list_for_each_entry_continue_reverse in setup_net Date: Sun, 16 Sep 2007 16:49:14 -0700 (PDT) Message-ID: <20070916.164914.15264075.davem@davemloft.net> References: <20070914144938.3ba643a5@oldman> <20070914220714.3a1e87f8@oldman> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: ebiederm@xmission.com, xemul@openvz.org, netdev@vger.kernel.org, containers@lists.osdl.org, devel@openvz.org, dlezcano@fr.ibm.com To: shemminger@linux-foundation.org Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:57920 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753063AbXIPXtP (ORCPT ); Sun, 16 Sep 2007 19:49:15 -0400 In-Reply-To: <20070914220714.3a1e87f8@oldman> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Stephen Hemminger Date: Fri, 14 Sep 2007 22:07:14 +0200 > Could we just make it so dev->init is not allowed to fail? Then it > can be a void function and the nasty unwind code can go? Someone (not me :-) need to do an audit to find all current users of this function and determine if they all can live without returning errors. If so, sure let's make the change and simplify things.