From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Sean Hefty <mshefty@ichips.intel.com>
Cc: netdev@vger.kernel.org, rdreier@cisco.com,
linux-kernel@vger.kernel.org, general@lists.openfabrics.org
Subject: Re: [ofa-general] Re: [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts.
Date: Mon, 17 Sep 2007 20:17:07 +0400 [thread overview]
Message-ID: <20070917161706.GA28431@2ka.mipt.ru> (raw)
In-Reply-To: <46EEA6A2.2080001@ichips.intel.com>
On Mon, Sep 17, 2007 at 09:09:06AM -0700, Sean Hefty (mshefty@ichips.intel.com) wrote:
> >>>+ addr = kmalloc(sizeof *addr, GFP_KERNEL);
> >>
> >>As a small nitpick: this wants to be sizeof(struct in_ifaddr)
>
> See chapter 14 of CodingStyle document. kmalloc(sizeof *addr... is correct.
Come on, do not start a flame war about how parameters into kmalloc
should be provided - there are much more serious issues unresolved yes. It
does help grepping the code, but if you feel that this is a serious threat,
then use your preferred way.
--
Evgeniy Polyakov
prev parent reply other threads:[~2007-09-17 16:17 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-13 19:16 [PATCH v2] iw_cxgb3: Support "iwarp-only" interfaces to avoid 4-tuple conflicts Steve Wise
2007-09-13 19:54 ` [ofa-general] " Sean Hefty
2007-09-15 14:07 ` Steve Wise
2007-09-23 20:33 ` Steve Wise
2007-09-14 13:09 ` [ofa-general] " Evgeniy Polyakov
2007-09-14 16:06 ` Roland Dreier
2007-09-15 15:56 ` Steve Wise
2007-09-16 14:22 ` [ofa-general] " Evgeniy Polyakov
2007-09-17 15:25 ` Steve Wise
2007-09-19 10:56 ` Evgeniy Polyakov
2007-09-21 15:10 ` [ofa-general] " Steve Wise
2007-09-17 16:09 ` Sean Hefty
2007-09-17 16:17 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070917161706.GA28431@2ka.mipt.ru \
--to=johnpol@2ka.mipt.ru \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mshefty@ichips.intel.com \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).