From: Christoph Hellwig <hch@infradead.org>
To: Andy Gospodarek <andy@greyhouse.net>
Cc: jeff@garzik.org, davem@davemloft.org, akpm@linux-foundation.org,
netdev@vger.kernel.org, baum@tehutinetworks.net
Subject: Re: [PATCH] tehuti: driver for Tehuti 10GbE network adapters
Date: Tue, 18 Sep 2007 10:47:23 +0100 [thread overview]
Message-ID: <20070918094723.GA2539@infradead.org> (raw)
In-Reply-To: <20070911164033.GA3754@gospo.rdu.redhat.com>
Some comment from looking at the driver in the -mm tree:
- please kill the CPU_CHIP_SWAP macros and use the normal linux
cpu_to_le*/le*_to_cpu and verify them using sparse.
See Documentation/sparse.txt on how to do that
- please include the linux header in the .c file, not the .h
- please don't redefine the dma mask constants
- please use the firmware loader instead of mebedding a firmware
image
- please don't invent your own debugging macros but use
dev_dbg and friends
- please kill the ENTER/RET macros
- please kill BDX_ASSERT
- the unregister_netdev directly followed by free_netdev in
bdx_remove look buggy, but I'm not entirely sure how to handle
multi-port devices properly here.
- please declare bdx_ethtool_ops on file-scope and kill
bdx_ethtool_ops
- please don't put assignments into conditionals ala
if ((err = pci_request_regions(pdev, BDX_DRV_NAME)))
goto err_dma;
but rather write
err = pci_request_regions(pdev, BDX_DRV_NAME);
if (err)
goto err_dma;
next prev parent reply other threads:[~2007-09-18 9:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 16:40 [PATCH] tehuti: driver for Tehuti 10GbE network adapters Andy Gospodarek
2007-09-14 15:36 ` Andy Gospodarek
2007-09-14 15:59 ` Jeff Garzik
2007-09-16 21:14 ` Andrew Morton
2007-09-17 16:54 ` Alexander Indenbaum
2007-09-18 9:47 ` Christoph Hellwig [this message]
2007-09-19 10:44 ` Alexander Indenbaum
2007-09-19 15:52 ` 'Christoph Hellwig'
2007-09-19 17:37 ` Alexander Indenbaum
2007-09-19 17:41 ` 'Christoph Hellwig'
2007-09-19 19:28 ` Alexander Indenbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918094723.GA2539@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andy@greyhouse.net \
--cc=baum@tehutinetworks.net \
--cc=davem@davemloft.org \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).