From: Krishna Kumar <krkumar2@in.ibm.com>
To: rdreier@cisco.com
Cc: netdev@vger.kernel.org, davem@davemloft.net,
general@lists.openfabrics.org
Subject: [ofa-general] [PATCH 2/2] IPoIB: Code cleanup
Date: Tue, 18 Sep 2007 16:48:17 +0530 [thread overview]
Message-ID: <20070918111817.1769.1042.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20070918111803.1769.60619.sendpatchset@localhost.localdomain>
Follow-up cleanup and "while loop" optimization in the poll handler.
net_rx_action guarantees that 'budget' is atleast 1.
Note: This could also be done for poll handlers of other drivers.
Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---
ipoib_ib.c | 22 ++++++++--------------
1 files changed, 8 insertions(+), 14 deletions(-)
diff -ruNp new1/drivers/infiniband/ulp/ipoib/ipoib_ib.c new2/drivers/infiniband/ulp/ipoib/ipoib_ib.c
--- new1/drivers/infiniband/ulp/ipoib/ipoib_ib.c 2007-09-18 16:14:20.000000000 +0530
+++ new2/drivers/infiniband/ulp/ipoib/ipoib_ib.c 2007-09-18 16:31:42.000000000 +0530
@@ -285,19 +285,16 @@ int ipoib_poll(struct napi_struct *napi,
{
struct ipoib_dev_priv *priv = container_of(napi, struct ipoib_dev_priv, napi);
struct net_device *dev = priv->dev;
- int done;
- int t;
- int n, i;
+ int num_wc, max_wc;
+ int done = 0;
- done = 0;
-
- while (done < budget) {
- int max = (budget - done);
+ do {
+ int i;
- t = min(IPOIB_NUM_WC, max);
- n = ib_poll_cq(priv->cq, t, priv->ibwc);
+ max_wc = min(IPOIB_NUM_WC, budget - done);
+ num_wc = ib_poll_cq(priv->cq, max_wc, priv->ibwc);
- for (i = 0; i < n; i++) {
+ for (i = 0; i < num_wc; i++) {
struct ib_wc *wc = priv->ibwc + i;
if (wc->wr_id & IPOIB_CM_OP_SRQ) {
@@ -309,10 +306,7 @@ int ipoib_poll(struct napi_struct *napi,
} else
ipoib_ib_handle_tx_wc(dev, wc);
}
-
- if (n != t)
- break;
- }
+ } while (num_wc == max_wc && done < budget);
if (done < budget) {
if (likely(!ib_req_notify_cq(priv->cq,
next prev parent reply other threads:[~2007-09-18 11:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 11:18 [ofa-general] [PATCH 1/2] IPoIB: Fix unregister_netdev hang Krishna Kumar
2007-09-18 11:18 ` Krishna Kumar [this message]
2007-09-18 14:27 ` Roland Dreier
2007-09-19 3:23 ` Krishna Kumar2
2007-09-19 3:30 ` [ofa-general] " Roland Dreier
2007-09-19 4:24 ` Krishna Kumar2
2007-09-18 17:58 ` [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule() Roland Dreier
2007-09-18 18:04 ` [ofa-general] [PATCH net-2.6.24] Fix documentation for dev_put()/dev_hold() Roland Dreier
2007-09-18 20:16 ` David Miller
2007-09-18 20:15 ` [ofa-general] Re: [PATCH net-2.6.24] Fix refcounting problem with netif_rx_reschedule() David Miller
2007-09-18 22:46 ` Roland Dreier
2007-09-18 22:50 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918111817.1769.1042.sendpatchset@localhost.localdomain \
--to=krkumar2@in.ibm.com \
--cc=davem@davemloft.net \
--cc=general@lists.openfabrics.org \
--cc=netdev@vger.kernel.org \
--cc=rdreier@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).