From: 'Christoph Hellwig' <hch@infradead.org>
To: Alexander Indenbaum <baum@tehutinetworks.net>
Cc: 'Christoph Hellwig' <hch@infradead.org>,
jeff@garzik.org, davem@davemloft.org, akpm@linux-foundation.org,
netdev@vger.kernel.org, 'Nadav Shemer' <nadav@tehutinetworks.net>,
'Andy Gospodarek' <andy@greyhouse.net>
Subject: Re: [PATCH] tehuti: driver for Tehuti 10GbE network adapters
Date: Wed, 19 Sep 2007 18:41:03 +0100 [thread overview]
Message-ID: <20070919174103.GB22795@infradead.org> (raw)
In-Reply-To: <20070919173724.C810375CC7@mail.tehutinetworks.co.il>
On Wed, Sep 19, 2007 at 07:37:18PM +0200, Alexander Indenbaum wrote:
> In my understanding unregister_netdev(), in case netdev is still IFF_UP and
> holds irq, will call dev_close() which will call netdev->stop(), bdx_close()
> in our case. bdx_close() releases all netdev resources among others calls
> free_irq().
>
> That's why I'm pretty sure that we do not hold any reference to netdev after
> unregister_netdev() finishes and we can free_netdev() without any worry :)
>
> What do you think, does it still look fishy?
Ok, so you do irq acquire/release in open/close so that bit is fine.
The code might actually work as is, sorry for the noise.
next prev parent reply other threads:[~2007-09-19 17:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 16:40 [PATCH] tehuti: driver for Tehuti 10GbE network adapters Andy Gospodarek
2007-09-14 15:36 ` Andy Gospodarek
2007-09-14 15:59 ` Jeff Garzik
2007-09-16 21:14 ` Andrew Morton
2007-09-17 16:54 ` Alexander Indenbaum
2007-09-18 9:47 ` Christoph Hellwig
2007-09-19 10:44 ` Alexander Indenbaum
2007-09-19 15:52 ` 'Christoph Hellwig'
2007-09-19 17:37 ` Alexander Indenbaum
2007-09-19 17:41 ` 'Christoph Hellwig' [this message]
2007-09-19 19:28 ` Alexander Indenbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070919174103.GB22795@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=andy@greyhouse.net \
--cc=baum@tehutinetworks.net \
--cc=davem@davemloft.org \
--cc=jeff@garzik.org \
--cc=nadav@tehutinetworks.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).