From: David Miller <davem@davemloft.net>
To: ilpo.jarvinen@helsinki.fi
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 5/9] [TCP]: Cleanup tcp_tso_acked and tcp_clean_rtx_queue
Date: Thu, 20 Sep 2007 11:33:53 -0700 (PDT) [thread overview]
Message-ID: <20070920.113353.82696899.davem@davemloft.net> (raw)
In-Reply-To: <11902906721671-git-send-email-ilpo.jarvinen@helsinki.fi>
From: "Ilpo_Järvinen" <ilpo.jarvinen@helsinki.fi>
Date: Thu, 20 Sep 2007 15:17:48 +0300
> Implements following cleanups:
> - Comment re-placement (CodingStyle)
> - tcp_tso_acked() local (wrapper-like) variable removal
> (readability)
> - __-types removed (IMHO they make local variables jumpy looking
> and just was space)
> - acked -> flag (naming conventions elsewhere in TCP code)
> - linebreak adjustments (readability)
> - nested if()s combined (reduced indentation)
> - clarifying newlines added
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>
Applied.
next prev parent reply other threads:[~2007-09-20 18:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 12:17 [PATCH net-2.6.24 0/9]: TCP improvements & cleanups Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 1/9] [TCP]: Maintain highest_sack accurately to the highest skb Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 2/9] [TCP]: Make fackets_out accurate Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 3/9] [TCP]: clear_all_retrans_hints prefixed by tcp_ Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 4/9] [TCP]: Move accounting from tso_acked to clean_rtx_queue Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 5/9] [TCP]: Cleanup tcp_tso_acked and tcp_clean_rtx_queue Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 6/9] [TCP] FRTO: Improve interoperability with other undo_marker users Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 7/9] [TCP] FRTO: Update sysctl documentation Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 8/9] [TCP]: Enable SACK enhanced FRTO (RFC4138) by default Ilpo Järvinen
2007-09-20 12:17 ` [PATCH 9/9] [TCP]: Avoid clearing sacktag hint in trivial situations Ilpo Järvinen
2007-09-20 18:41 ` David Miller
2007-09-20 19:18 ` Ilpo Järvinen
2007-09-20 18:36 ` [PATCH 8/9] [TCP]: Enable SACK enhanced FRTO (RFC4138) by default David Miller
2007-09-20 18:35 ` [PATCH 7/9] [TCP] FRTO: Update sysctl documentation David Miller
2007-09-20 18:35 ` [PATCH 6/9] [TCP] FRTO: Improve interoperability with other undo_marker users David Miller
2007-09-20 18:33 ` David Miller [this message]
2007-09-20 18:33 ` [PATCH 4/9] [TCP]: Move accounting from tso_acked to clean_rtx_queue David Miller
2007-09-20 18:31 ` [PATCH 3/9] [TCP]: clear_all_retrans_hints prefixed by tcp_ David Miller
2007-09-20 18:30 ` [PATCH 2/9] [TCP]: Make fackets_out accurate David Miller
2007-09-20 18:29 ` [PATCH 1/9] [TCP]: Maintain highest_sack accurately to the highest skb David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070920.113353.82696899.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).