From: Krishna Kumar <krkumar2@in.ibm.com>
To: auke-jan.h.kok@intel.com
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Krishna Kumar <krkumar2@in.ibm.com>
Subject: [PATCH] E1000: Do not allow requeue of freed skb
Date: Fri, 21 Sep 2007 10:30:43 +0530 [thread overview]
Message-ID: <20070921050043.9603.76335.sendpatchset@localhost.localdomain> (raw)
Returning BUSY will make qdisc_restart enqueue the skb which was already
freed. The bad skb was correctly freed and we should return NETDEV_TX_OK.
Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---
diff -ruNp a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
--- a/drivers/net/e1000e/netdev.c 2007-09-21 10:23:29.000000000 +0530
+++ b/drivers/net/e1000e/netdev.c 2007-09-21 10:24:20.000000000 +0530
@@ -3531,7 +3531,7 @@ static int e1000_xmit_frame(struct sk_bu
/* handle pci_map_single() error in e1000_tx_map */
dev_kfree_skb_any(skb);
spin_unlock_irqrestore(&adapter->tx_queue_lock, irq_flags);
- return NETDEV_TX_BUSY;
+ return NETDEV_TX_OK;
}
e1000_tx_queue(adapter, tx_flags, count);
reply other threads:[~2007-09-21 4:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070921050043.9603.76335.sendpatchset@localhost.localdomain \
--to=krkumar2@in.ibm.com \
--cc=auke-jan.h.kok@intel.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).