From: Christoph Hellwig <hch@infradead.org>
To: Zhu Yi <yi.zhu@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"John W. Linville" <linville@tuxdriver.com>,
davem@davemloft.net, jeff@garzik.org, netdev@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: Please pull 'iwlwifi' branch of wireless-2.6
Date: Fri, 21 Sep 2007 09:05:00 +0100 [thread overview]
Message-ID: <20070921080500.GA29050@infradead.org> (raw)
In-Reply-To: <1190337630.5718.136.camel@debian.sh.intel.com>
On Fri, Sep 21, 2007 at 09:20:30AM +0800, Zhu Yi wrote:
> > The depends on m for CONFIG_IWL4965 and CONFIG_IWL3945 needs to go,
> > we don't put drivers int that need to be modular.
>
> Since we splited the code base for 3945 and 4965 by a simple "fork" of
> file iwl-base.c, some non-static functions names remain the same. Make
> the two drivers build into vmlinux at the same time will cause conflict.
> So to make them depend on m is a current workaround for .24. We will
> abstract a common iwl-core.ko and make driver specific iwl3945.ko and
> iwl4965.ko depend on it in .25 time frame.
This kind of stuff is not what we want to leak into mainline. If you're
too busy to do that 5 minute sed search and replace I'll do it for you.
prev parent reply other threads:[~2007-09-21 8:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-18 18:50 Please pull 'iwlwifi' branch of wireless-2.6 John W. Linville
[not found] ` <20070918185040.GF4940-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2007-09-18 19:22 ` David Miller
[not found] ` <20070918.122258.82101397.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2007-09-19 13:28 ` Jeff Garzik
[not found] ` <46F12414.8000900-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
2007-09-19 14:57 ` John W. Linville
2007-09-19 10:13 ` Christoph Hellwig
[not found] ` <20070919101326.GA32432-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
2007-09-21 1:20 ` Zhu Yi
2007-09-21 1:34 ` John W. Linville
2007-09-26 2:31 ` David Miller
2007-09-21 8:05 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070921080500.GA29050@infradead.org \
--to=hch@infradead.org \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).