From: Stephen Hemminger <shemminger@linux-foundation.org>
To: netdev@vger.kernel.org
Subject: [RFC] Zero-length write() does not generate a datagram on connected socket
Date: Mon, 24 Sep 2007 15:34:35 -0700 [thread overview]
Message-ID: <20070924153435.14249225@freepuppy.rosehill> (raw)
In-Reply-To: <20070922094432.E9BEA108010@picon.linux-foundation.org>
The bug http://bugzilla.kernel.org/show_bug.cgi?id=5731
describes an issue where write() can't be used to generate a zero-length
datagram (but send, and sendto do work).
I think the following is needed:
--- a/net/socket.c 2007-08-20 09:54:28.000000000 -0700
+++ b/net/socket.c 2007-09-24 15:31:25.000000000 -0700
@@ -777,8 +777,11 @@ static ssize_t sock_aio_write(struct kio
if (pos != 0)
return -ESPIPE;
- if (iocb->ki_left == 0) /* Match SYS5 behaviour */
- return 0;
+ if (unlikely(iocb->ki_left == 0)) {
+ struct socket *sock = iocb->ki_filp->private_data;
+ if (sock->type == SOCK_STREAM)
+ return 0;
+ }
x = alloc_sock_iocb(iocb, &siocb);
if (!x)
next parent reply other threads:[~2007-09-24 22:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-5731-100@http.bugzilla.kernel.org/>
[not found] ` <20070922094432.E9BEA108010@picon.linux-foundation.org>
2007-09-24 22:34 ` Stephen Hemminger [this message]
2007-09-26 3:18 ` [RFC] Zero-length write() does not generate a datagram on connected socket Herbert Xu
2007-09-26 5:36 ` Stephen Hemminger
2007-09-26 17:17 ` Rick Jones
2007-09-26 18:47 ` Vlad Yasevich
2007-09-27 20:53 ` David Miller
2007-09-27 22:41 ` Stephen Hemminger
2007-09-28 8:49 ` Michael Kerrisk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070924153435.14249225@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox