From: David Miller <davem@davemloft.net>
To: hadi@cyberus.ca
Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org,
kaber@trash.net, dada1@cosmosbay.com, johnpol@2ka.mipt.ru
Subject: Re: [RFC][NET_SCHED] explict hold dev tx lock
Date: Tue, 25 Sep 2007 19:28:11 -0700 (PDT) [thread overview]
Message-ID: <20070925.192811.08341847.davem@davemloft.net> (raw)
In-Reply-To: <1190256183.4818.28.camel@localhost>
From: jamal <hadi@cyberus.ca>
Date: Wed, 19 Sep 2007 22:43:03 -0400
> [NET_SCHED] explict hold dev tx lock
>
> For N cpus, with full throttle traffic on all N CPUs, funneling traffic
> to the same ethernet device, the devices queue lock is contended by all
> N CPUs constantly. The TX lock is only contended by a max of 2 CPUS.
> In the current mode of operation, after all the work of entering the
> dequeue region, we may endup aborting the path if we are unable to get
> the tx lock and go back to contend for the queue lock. As N goes up,
> this gets worse.
>
> The changes in this patch result in a small increase in performance
> with a 4CPU (2xdual-core) with no irq binding. Both e1000 and tg3
> showed similar behavior;
>
> Signed-off-by: Jamal Hadi Salim <hadi@cyberus.ca>
I've applied this to net-2.6.24, although I want to study more deeply
the implications of this change myself at some point :)
next prev parent reply other threads:[~2007-09-26 2:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-16 16:14 [RFC][NET_SCHED] explict hold dev tx lock jamal
2007-09-16 19:31 ` David Miller
2007-09-16 20:41 ` jamal
2007-09-16 20:52 ` jamal
2007-09-16 21:10 ` jamal
2007-09-17 10:27 ` Evgeniy Polyakov
2007-09-17 13:03 ` jamal
2007-09-17 13:58 ` Evgeniy Polyakov
2007-09-18 2:01 ` David Miller
2007-09-18 2:48 ` jamal
2007-09-19 13:33 ` jamal
2007-09-19 16:09 ` David Miller
2007-09-20 2:33 ` jamal
2007-09-20 2:43 ` jamal
2007-09-26 2:28 ` David Miller [this message]
2007-09-26 13:11 ` jamal
2007-10-09 4:00 ` Herbert Xu
2007-10-09 13:43 ` jamal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925.192811.08341847.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dada1@cosmosbay.com \
--cc=hadi@cyberus.ca \
--cc=herbert@gondor.apana.org.au \
--cc=johnpol@2ka.mipt.ru \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).