From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, jgarzik@pobox.com, akpm@linux-foundation.org
Subject: Re: [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6
Date: Tue, 25 Sep 2007 22:11:15 -0700 (PDT) [thread overview]
Message-ID: <20070925.221115.26296263.davem@davemloft.net> (raw)
In-Reply-To: <1190781398.17052.18.camel@localhost>
From: Joe Perches <joe@perches.com>
Date: Tue, 25 Sep 2007 21:36:38 -0700
> On Tue, 2007-09-25 at 19:29 -0700, David Miller wrote:
> > I'm going to hold on this for now, there is no universal
> > agreement that this is something we want to do and I'd
> > like to take care of getting the more certain stuff into
> > net-2.6.24 before "iffy" bits like this one.
>
> Here's an argument for inclusion:
>
> defconfig without patches:
Sure, but this ignores certain things that text/data/bss
size don't show you.
For one thing, stack frames might now be larger in the
functions where the new variables get added, even if they
aren't used to print out the debugging message. And that
could have negative performance implications.
Nothing is every black and white, everything is gray :-)
next prev parent reply other threads:[~2007-09-26 5:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-20 6:53 [PATCH - net-2.6.24 0/2] Introduce and use print_ip and print_ipv6 Joe Perches
2007-09-20 14:55 ` Randy Dunlap
2007-09-20 15:25 ` Joe Perches
2007-09-20 17:46 ` Ilpo Järvinen
2007-09-20 23:05 ` Thomas Graf
2007-09-20 23:20 ` Joe Perches
2007-09-26 2:29 ` David Miller
2007-09-26 4:36 ` Joe Perches
2007-09-26 5:11 ` David Miller [this message]
2007-09-26 5:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070925.221115.26296263.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=joe@perches.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).