Re: [PATCH 2/7] CAN: Add PF_CAN core module

Stephen Hemminger
2007-09-25T15:35:21Z

On 25 Sep 2007 15:24:33 +0200
Urs Thuermann <urs@isnogud.escape.de> wrote:

> Arnaldo Carvalho de Melo <acme@ghostprotocols.net> writes:
>
> > > + skb_queue_purge(&sk->sk_receive_queue);
> > > + if (sk->sk_protinfo)
> > > + kfree(sk->sk_protinfo);
> > > +}
> >
> > Is it really needed to do this sk_protinfo check?
>
> Thanks for finding this. This is from 2.6.12 times or so. We have
> other CAN protocol (which we are not allowed to put under GPL)
> implemenatations which still use the protinfo field. But we should
> change those and I will delete this check.
>
> urs

Then please make all exported symbols marked EXPORT_SYMBOL_GPL to make
sure that the other CAN protocol can not reuse your infrastructure.

--
Stephen Hemminger <shemminger@linux-foundation.org>