Re: [PATCH 2/7] CAN: Add PF_CAN core module

Sam Ravnborg
2007-11-15T15:08:10Z

> > > +
> > > +struct timer_list stattimer; /* timer for statistics update */
> > > +struct s_stats stats; /* packet statistics */
> > > +struct s_pstats pstats; /* receive list statistics */
> >
> > More global variables without prefix.
>
> These variables are not exported with EXPORT_SYMBOL, so there should
> be no name conflict. They cannot be made static because they are used
> in af_can.c and proc.c. Nevertheless we can prefix them with can_ if
> you still think it's necessary.

When this is build-in they will be in the global kernel namespace.
So please add can_ prefix.

Sam