Re: [PATCH 2/7] CAN: Add PF_CAN core module

Urs Thuermann
2007-11-16T14:35:28Z

David Miller <davem@davemloft.net> writes:

> I really frown upon these local debugging macros people tend to want
> to submit with their changes.
>
> It really craps up the tree, even though it might be useful to you.

We have now removed the debug code completely. The code is quite
stable and we won't need these remnants from early days anymore.

> So please remove this stuff or replace the debugging statements
> with some generic kernel debugging facility, there are several.

I am not aware of any useful kernel facilities to replace our debug
macros, i.e. printing of debug messages, controlled by a bit mask
passed in as a module parameter, hexdumping of fames, etc. Of course,
there are other things like kprobes but sometimes printk(KERN_DEBUG...)
is more convenient and that's why people write their own DBG() macros.

urs