Re: [PATCH 2/7] CAN: Add PF_CAN core module

Sam Ravnborg
2007-11-15T15:09:58Z

On Thu, Nov 15, 2007 at 04:05:30AM -0800, David Miller wrote:
> From: Urs Thuermann <urs.thuermann@gmx.de>
> Date: 15 Nov 2007 12:51:34 +0100
>
> > I prefer our code because it is shorter (fits into one line) and can
> > be used anywhere where an expression is allowed compared to only where
> > a statement is allowed. Actually, I first had
> >
> > #define DBG( ... ) ((debug & 1) && printk( ... ))
> >
> > and so on, but that didn't work with can_debug_{cframe,sbk} since they
> > return void.
> >
> > Admitted, the benefit of expr vs. statement is really negligible and
> > since this issue has come up several times I will change these macros
> > using do-while.
>
> I really frown upon these local debugging macros people tend to want
> to submit with their changes.
>
> It really craps up the tree, even though it might be useful to you.
>
> So please remove this stuff or replace the debugging statements
> with some generic kernel debugging facility, there are several.

It would be usefull if someone could make a short intro to the preferred
ones and we could stuff it in Documentation/*

Had same comment but had nowhere to point the can guys at.

Sam