From: David Miller <davem@davemloft.net>
To: ebiederm@xmission.com
Cc: dlezcano@fr.ibm.com, benjamin.thery@bull.net, dev@sw.ru,
den@sw.ru, containers@lists.osdl.org, netdev@vger.kernel.org
Subject: Re: [PATCH] netns: Simplify the network namespace list locking rules.
Date: Wed, 26 Sep 2007 22:40:22 -0700 (PDT) [thread overview]
Message-ID: <20070926.224022.54462669.davem@davemloft.net> (raw)
In-Reply-To: <m1r6kkrce0.fsf@ebiederm.dsl.xmission.com>
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Wed, 26 Sep 2007 21:54:47 -0600
>
> Denis V. Lunev <den@sw.ru> noticed that the locking rules
> for the network namespace list are over complicated and broken.
>
> In particular the current register_netdev_notifier currently
> does not take any lock making the for_each_net iteration racy
> with network namespace creation and destruction. Oops.
>
> The fact that we need to use for_each_net in rtnl_unlock() when
> the rtnetlink support becomes per network namespace makes designing
> the proper locking tricky. In addition we need to be able to call
> rtnl_lock() and rtnl_unlock() when we have the net_mutex held.
>
> After thinking about it and looking at the alternatives carefully
> it looks like the simplest and most maintainable solution is
> to remove net_list_mutex altogether, and to use the rtnl_mutex instead.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Applied, thanks Eric.
prev parent reply other threads:[~2007-09-27 5:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46F3C777.7070103@sw.ru>
2007-09-27 3:54 ` [PATCH] netns: Simplify the network namespace list locking rules Eric W. Biederman
2007-09-27 5:21 ` Denis V. Lunev
2007-09-27 5:40 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070926.224022.54462669.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=benjamin.thery@bull.net \
--cc=containers@lists.osdl.org \
--cc=den@sw.ru \
--cc=dev@sw.ru \
--cc=dlezcano@fr.ibm.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox