From: Stephen Hemminger <shemminger@linux-foundation.org>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: David Miller <davem@davemloft.net>, <netdev@vger.kernel.org>,
Linux Containers <containers@lists.osdl.org>
Subject: Re: [PATCH] net: Fix running without sysfs
Date: Wed, 26 Sep 2007 17:07:14 -0700 [thread overview]
Message-ID: <20070926170714.04afe275@freepuppy.rosehill> (raw)
In-Reply-To: <m1zlz9rnt1.fsf@ebiederm.dsl.xmission.com>
On Wed, 26 Sep 2007 17:48:10 -0600
ebiederm@xmission.com (Eric W. Biederman) wrote:
>
> When sysfs support is compiled out the kernel still keeps and maintains
> the kobject tree. So it is not safe to skip our kobject reference counting or
> to avoid becoming members of the kobject tree. It is safe to not add
> the networking specific sysfs attributes.
>
> This patch removes the sysfs special cases from net/core/dev.c
> renames functions from netdev_sysfs_xxxx to netdev_kobject_xxxx
> and always compiles in net-sysfs.c
>
> net-sysfs.c is modified with a CONFIG_SYSFS guard around the parts
> that are actually sysfs specific.
>
> Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Acked-by: Stephen Hemminger <shemminger@linux-foundation.org>
Looks good. It also fixes a use after-free in netdev_run_todo
when !CONFIG_SYSFS
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-09-27 0:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-26 23:48 [PATCH] net: Fix running without sysfs Eric W. Biederman
2007-09-27 0:07 ` Stephen Hemminger [this message]
2007-09-27 5:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070926170714.04afe275@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=containers@lists.osdl.org \
--cc=davem@davemloft.net \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox