* Re: [PATCH] rfkill: Move rfkill_switch_all out of global header
2007-09-27 22:07 [PATCH] rfkill: Move rfkill_switch_all out of global header Ivo van Doorn
@ 2007-09-27 21:57 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2007-09-27 21:57 UTC (permalink / raw)
To: ivdoorn; +Cc: dtor, netdev, linux-wireless
From: Ivo van Doorn <ivdoorn@gmail.com>
Date: Fri, 28 Sep 2007 00:07:41 +0200
> rfkill_switch_all shouldn't be called by drivers directly,
> instead they should send a signal over the input device.
>
> To prevent confusion for driver developers, move the
> function into a rfkill private header.
>
> Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
Applied to net-2.6.24, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] rfkill: Move rfkill_switch_all out of global header
@ 2007-09-27 22:07 Ivo van Doorn
2007-09-27 21:57 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Ivo van Doorn @ 2007-09-27 22:07 UTC (permalink / raw)
To: davem; +Cc: Dmitry Torokhov, netdev, linux-wireless
rfkill_switch_all shouldn't be called by drivers directly,
instead they should send a signal over the input device.
To prevent confusion for driver developers, move the
function into a rfkill private header.
Signed-off-by: Ivo van Doorn <IvDoorn@gmail.com>
---
diff --git a/include/linux/rfkill.h b/include/linux/rfkill.h
index f9a50da..67096b5 100644
--- a/include/linux/rfkill.h
+++ b/include/linux/rfkill.h
@@ -2,7 +2,7 @@
#define __RFKILL_H
/*
- * Copyright (C) 2006 Ivo van Doorn
+ * Copyright (C) 2006 - 2007 Ivo van Doorn
* Copyright (C) 2007 Dmitry Torokhov
*
* This program is free software; you can redistribute it and/or modify
@@ -84,6 +84,4 @@ void rfkill_free(struct rfkill *rfkill);
int rfkill_register(struct rfkill *rfkill);
void rfkill_unregister(struct rfkill *rfkill);
-void rfkill_switch_all(enum rfkill_type type, enum rfkill_state state);
-
#endif /* RFKILL_H */
diff --git a/net/rfkill/rfkill-input.c b/net/rfkill/rfkill-input.c
index 8e4516a..eaabf08 100644
--- a/net/rfkill/rfkill-input.c
+++ b/net/rfkill/rfkill-input.c
@@ -17,6 +17,8 @@
#include <linux/init.h>
#include <linux/rfkill.h>
+#include "rfkill-input.h"
+
MODULE_AUTHOR("Dmitry Torokhov <dtor@mail.ru>");
MODULE_DESCRIPTION("Input layer to RF switch connector");
MODULE_LICENSE("GPL");
diff --git a/net/rfkill/rfkill-input.h b/net/rfkill/rfkill-input.h
new file mode 100644
index 0000000..4dae500
--- /dev/null
+++ b/net/rfkill/rfkill-input.h
@@ -0,0 +1,16 @@
+/*
+ * Copyright (C) 2007 Ivo van Doorn
+ */
+
+/*
+ * This program is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU General Public License version 2 as published
+ * by the Free Software Foundation.
+ */
+
+#ifndef __RFKILL_INPUT_H
+#define __RFKILL_INPUT_H
+
+void rfkill_switch_all(enum rfkill_type type, enum rfkill_state state);
+
+#endif /* __RFKILL_INPUT_H */
diff --git a/net/rfkill/rfkill.c b/net/rfkill/rfkill.c
index 03ed7fd..00ee534 100644
--- a/net/rfkill/rfkill.c
+++ b/net/rfkill/rfkill.c
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2006 Ivo van Doorn
+ * Copyright (C) 2006 - 2007 Ivo van Doorn
* Copyright (C) 2007 Dmitry Torokhov
*
* This program is free software; you can redistribute it and/or modify
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-09-27 21:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-09-27 22:07 [PATCH] rfkill: Move rfkill_switch_all out of global header Ivo van Doorn
2007-09-27 21:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).