From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Jochen Voß" <voss@seehuhn.de>
Cc: Jeff Garzik <jgarzik@pobox.com>, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: sky2 FE+ receive status workaround
Date: Thu, 27 Sep 2007 06:58:07 -0700 [thread overview]
Message-ID: <20070927065807.7a71ae89@freepuppy.rosehill> (raw)
In-Reply-To: <4C6E8545-ADDC-456E-B17B-B3512A6047D1@seehuhn.de>
On Thu, 27 Sep 2007 09:14:11 +0100
Jochen Voß <voss@seehuhn.de> wrote:
> Hi Stephen,
>
> On 27 Sep 2007, at 01:58, Stephen Hemminger wrote:
> > + /* This chip has hardware problems that generates bogus status.
> > + * So do only marginal checking and expect higher level protocols
> > + * to handle crap frames.
> > + */
> > + if (sky2->hw->chip_id == CHIP_ID_YUKON_FE_P &&
> > + sky2->hw->chip_rev == CHIP_REV_YU_FE2_A0 &&
> > + length != count)
> > + goto okay;
>
> Shouldn't the condition be "length == count"?
>
No, the code is correct as is. Basically if length == count, then
the status field is correct, and the driver can go ahead and use it.
If length != count, then the status is bogus but the data is okay.
--
Stephen Hemminger <shemminger@linux-foundation.org>
next prev parent reply other threads:[~2007-09-27 14:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-27 0:58 [PATCH] sky2: sky2 FE+ receive status workaround Stephen Hemminger
2007-09-27 8:14 ` Jochen Voß
2007-09-27 13:58 ` Stephen Hemminger [this message]
2007-09-27 15:23 ` Jochen Voss
2007-09-27 19:32 ` [PATCH 1/2] sky2: FE+ vlan workaround Stephen Hemminger
2007-09-28 3:35 ` Jeff Garzik
2007-09-27 19:38 ` [PATCH 2/2] sky2: fix transmit state on resume Stephen Hemminger
2007-09-28 3:35 ` Jeff Garzik
2007-09-28 3:33 ` [PATCH] sky2: sky2 FE+ receive status workaround Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070927065807.7a71ae89@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=voss@seehuhn.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox