[PATCH] proper comment for loopback initialization order

[PATCH] proper comment for loopback initialization order

[Denis V. Lunev]

Loopback device is special. It should be initialized at the very
beginning.  Initialization order has been changed by
Eric W. Biederman <ebiederm@xmission.com> and this change is non-obvious
and important enough to add proper comment.

Signed-off-by: Denis V. Lunev <den@openvz.org>

--- ./drivers/net/loopback.c.loopcomment	2007-08-26 19:30:38.000000000 +0400
+++ ./drivers/net/loopback.c	2007-09-27 16:08:06.000000000 +0400
@@ -293,4 +293,6 @@ static int __init loopback_init(void)
 	return register_pernet_device(&loopback_net_ops);
 }
 
+/* Loopback is special. It should be initialized before any other network
+   device and network subsystem */
 fs_initcall(loopback_init);

Re: [PATCH] proper comment for loopback initialization order

[David Miller]

From: "Denis V. Lunev" <den@openvz.org>
Date: Thu, 27 Sep 2007 16:25:27 +0400

> Subject: [PATCH] proper comment for loopback initialization order
> From: "Denis V. Lunev" <den@openvz.org>
> To: davem@davemloft.net
> Cc: dev@openvz.org, devel@openvz.org, netdev@vger.kernel.org,
> 	containers@lists.osdl.org
> Date: Thu, 27 Sep 2007 16:25:27 +0400
> Sender:  <den@sw.ru>
> User-Agent: Mutt/1.5.16 (2007-06-09)
> 
> Loopback device is special. It should be initialized at the very
> beginning.  Initialization order has been changed by
> Eric W. Biederman <ebiederm@xmission.com> and this change is non-obvious
> and important enough to add proper comment.
> 
> Signed-off-by: Denis V. Lunev <den@openvz.org>

Applied, but I had to fix the coding style of your comment,
please do it like this in the future:

/* Loopback is special. It should be initialized before any other network
 * device and network subsystem.
 */

Thanks.