Netdev List
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Satoshi OSHIMA <satoshi.oshima.fk@hitachi.com>
Cc: "Andi Kleen" <andi@firstfloor.org>,
	netdev <netdev@vger.kernel.org>,
	"吉藤 英明" <yoshfuji@linux-ipv6.org>,
	"Yumiko SUGITA" <yumiko.sugita.yf@hitachi.com>,
	"青木@RedHat" <haoki@redhat.com>
Subject: Re: [RFC/PATCH 3/3] UDP memory usage accounting (take 2): measurement
Date: Fri, 28 Sep 2007 18:37:12 +0400	[thread overview]
Message-ID: <20070928143710.GA16747@2ka.mipt.ru> (raw)
In-Reply-To: <46FD048B.9010409@hitachi.com>

On Fri, Sep 28, 2007 at 10:41:31PM +0900, Satoshi OSHIMA (satoshi.oshima.fk@hitachi.com) wrote:
> This patch introduces memory usage measurement for UDP.
> 
> These 3 points were updated.
> 
> - UDP specific codes in IP layer were removed.
> 
> - atomic_sub() in a loop was removed
> 
> - accounting during socket destruction

Another approach is to account only at the highest UDP layer and having
datagram skb destructor just like it is done in TCP, but this approach
is also resonable.

I already told that patches 1 and 3 have broken indent, please fix that.

A hint: when you are about to submit something network related for inclusion,
and strongly believes it is ready, it can be a not that bad idea to add 
David Miller <davem@davemloft.net> to copy list, he can complain about
backlog and so on, but will read you mail twice :) but do not tell anyone.

-- 
	Evgeniy Polyakov

  reply	other threads:[~2007-09-28 14:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-28 13:41 [RFC/PATCH 3/3] UDP memory usage accounting (take 2): measurement Satoshi OSHIMA
2007-09-28 14:37 ` Evgeniy Polyakov [this message]
2007-10-01 13:52   ` Satoshi OSHIMA

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070928143710.GA16747@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=andi@firstfloor.org \
    --cc=haoki@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=satoshi.oshima.fk@hitachi.com \
    --cc=yoshfuji@linux-ipv6.org \
    --cc=yumiko.sugita.yf@hitachi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox