From: Stephen Hemminger <shemminger@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: cebbert@redhat.com, netdev@vger.kernel.org
Subject: Re: Null dereference in socket.c
Date: Fri, 28 Sep 2007 16:42:42 -0700 [thread overview]
Message-ID: <20070928164242.540b945a@freepuppy.rosehill> (raw)
In-Reply-To: <20070928.160057.132434706.davem@davemloft.net>
On Fri, 28 Sep 2007 16:00:57 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Chuck Ebbert <cebbert@redhat.com>
> Date: Fri, 28 Sep 2007 18:58:36 -0400
>
> > After debugging an oops (https://bugzilla.redhat.com/attachment.cgi?id=209231)
> > I find it happens here in socket.c::sock_ioctl() line 902:
> >
> > default:
> > =============> err = sock->ops->ioctl(sock, cmd, arg);
> >
> > /*
> > * If this ioctl is unknown try to hand it down
> > * to the NIC driver.
> > */
> > if (err == -ENOIOCTLCMD)
> > err = dev_ioctl(cmd, argp);
> > break;
> >
> >
> > ioctl is NULL and the kernel jumps to address 0. Should we add a check
> > for that?
> >
> > Bug report:
> > https://bugzilla.redhat.com/show_bug.cgi?id=306801
>
> Every protocol should provide a non-NULL ->ioctl() method,
> find out which one isn't and fix it
Auditing the net-2.6.24 tree all instances found by cscope are safe.
--
Stephen Hemminger <shemminger@linux-foundation.org>
prev parent reply other threads:[~2007-09-28 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-28 22:58 Null dereference in socket.c Chuck Ebbert
2007-09-28 23:00 ` David Miller
2007-09-28 23:42 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070928164242.540b945a@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=cebbert@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox