From: Stephen Hemminger <shemminger@linux-foundation.org>
To: akpm@linux-foundation.org
Cc: jeff@garzik.org, netdev@vger.kernel.org,
akpm@linux-foundation.org, eswierk@arastra.com,
aabdulla@nvidia.com
Subject: Re: [patch 09/13] forcedeth: "no link" is informational
Date: Tue, 2 Oct 2007 14:49:24 -0700 [thread overview]
Message-ID: <20071002144924.2055022d@freepuppy.rosehill> (raw)
In-Reply-To: <200710022111.l92LBf6c022501@imap1.linux-foundation.org>
On Tue, 02 Oct 2007 14:11:41 -0700
akpm@linux-foundation.org wrote:
> From: "Ed Swierk" <eswierk@arastra.com>
>
> Log "no link during initialization" at KERN_INFO as it's not an error, and
> occurs every time the interface comes up (when the forcedeth-phy-power-down
> patch is applied).
>
> Signed-off-by: Ed Swierk <eswierk@arastra.com>
> Cc: Ayaz Abdulla <aabdulla@nvidia.com>
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> drivers/net/forcedeth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/net/forcedeth.c~forcedeth-no-link-is-informational drivers/net/forcedeth.c
> --- a/drivers/net/forcedeth.c~forcedeth-no-link-is-informational
> +++ a/drivers/net/forcedeth.c
> @@ -4921,7 +4921,7 @@ static int nv_open(struct net_device *de
> if (ret) {
> netif_carrier_on(dev);
> } else {
> - printk("%s: no link during initialization.\n", dev->name);
> + printk(KERN_INFO "%s: no link during initialization.\n", dev->name);
> netif_carrier_off(dev);
> }
> if (oom)
Driver should use netif_msg_link_up()
--
Stephen Hemminger <shemminger@linux-foundation.org>
prev parent reply other threads:[~2007-10-02 21:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-02 21:11 [patch 09/13] forcedeth: "no link" is informational akpm
2007-10-02 21:49 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071002144924.2055022d@freepuppy.rosehill \
--to=shemminger@linux-foundation.org \
--cc=aabdulla@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=eswierk@arastra.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox